Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Bug/core redis#119

Open
ptcar2009 wants to merge 6 commits intodevelopfrom
bug/CORE-redis
Open

Bug/core redis#119
ptcar2009 wants to merge 6 commits intodevelopfrom
bug/CORE-redis

Conversation

@ptcar2009
Copy link
Copy Markdown
Contributor

Description

Kind: fix/feature

Section: helm chart

Summary: changes helm and uidp configuration to rely less heavily on init jobs and more on static value generation

Changelog

  • features:
    • changes password and init key generation to be helm based
    • changes helm password usage to not always use password
    • changes init jobs to init containers, to not always create jobs when installing

Pay attention to

  • Init container method might not be the best solution if uidp/insprd need to be replicated, but it's simpler and more intuitive on a first step.
  • There might be ways to generate ssh keys automatically via helm chart, didn't go too deep into it, but there might be a way, which would make the secret generator obsolete (which is a good thing)

@ptcar2009 ptcar2009 requested a review from a team as a code owner August 24, 2021 22:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 24, 2021

Codecov Report

Merging #119 (8b1330f) into develop (0496bd6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #119   +/-   ##
========================================
  Coverage    74.93%   74.93%           
========================================
  Files          116      116           
  Lines         6384     6384           
========================================
  Hits          4784     4784           
  Misses        1362     1362           
  Partials       238      238           
Flag Coverage Δ
unittests 74.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0496bd6...8b1330f. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant