Conversation
…tting service list
wknet123
reviewed
Mar 4, 2021
| func GetServiceList(name string, userID int64, source *int, sourceid *int64) ([]*model.ServiceStatusMO, error) { | ||
| query := model.ServiceStatusFilter{Name: name, Source: source, SourceID: sourceid} | ||
| func GetServiceList(name string, projectID int64, userID int64, source *int, sourceid *int64) ([]*model.ServiceStatusMO, error) { | ||
| query := model.ServiceStatusFilter{Name: name, ProjectID: projectID, Source: source, SourceID: sourceid} |
Collaborator
There was a problem hiding this comment.
I think we should change or add a SQL query instead to pass a specific parameter.
Contributor
Author
There was a problem hiding this comment.
This change is reuse the SQL，and improve the function of "ServiceStatusFilter"。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tting service list
fix #686