Change development flow to allow removing generated files, using proj…#267
Change development flow to allow removing generated files, using proj…#267FredrikAtIBM wants to merge 1 commit intomainfrom
Conversation
konrad-ohms
left a comment
There was a problem hiding this comment.
Looks like removing the dependencies in the Makefile failed the build, I think the deepcopy file is missing, could you take a second look please?
356ab41 to
cc6c33d
Compare
18d708a to
f445235
Compare
Thanks. The generated files no longer exist. This is intended behavior. The pipelines will just have to facilitate the new changes. |
f445235 to
b10c067
Compare
46a14ea to
77825e7
Compare
7c3095e to
411d593
Compare
…ect level binaries and commit hooks Signed-off-by: Fredrik Gundersen <fredrik.gundersen@ibm.com>
411d593 to
faa67b0
Compare
| BUILDPLATFORM ?= linux/${ARCH} | ||
| BUILDTARGET ?= linux/${ARCH} | ||
| GIT_COMMIT ?= $(shell git rev-parse --short HEAD) | ||
| container-build: ## Build docker image with the manager. |
There was a problem hiding this comment.
| container-build: ## Build docker image with the manager. | |
| container-build: buildctl ## Build docker image with the manager. |
If you don't define the dependency to check the service is running, you can run into errors when the buildkitd container is not running.
Example:
$ make container-build
/home/ohmsk/git/instana-public/instana-agent-operator/bin/buildctl --addr=podman-container://buildkitd build \
--frontend=dockerfile.v0 \
--local context=. \
--local dockerfile=. \
--opt build-arg:VERSION=0.0.1 \
--opt build-arg:GIT_COMMIT=faa67b0 \
--opt build-arg:DATE="$(date)" \
--opt build-arg:BUILDPLATFORM=linux/amd64 \
--opt build-arg:TARGETPLATFORM= \
--opt filename=Containerfile \
--output type=oci,name=delivery.instana.io/dev-sandbox-docker-all/konrad/instana-agent-operator:konrad | podman load
[+] Building 0.0s (0/0)
error: listing workers for Build: failed to list workers: Unavailable: connection error: desc = "error reading server preface: command [podman exec -i buildkitd buildctl dial-stdio] has exited with exit status 255, make sure the URL is valid, and Docker 18.09 or later is installed on the remote host: stderr=Error: can only create exec sessions on running containers: container state improper\n"
Error: payload does not match any of the supported image formats:
* oci: open /var/tmp/podman3981212783/index.json: not a directory
* oci-archive: loading index: open /var/tmp/container_images_oci1704363624/index.json: no such file or directory
* docker-archive: loading tar component "manifest.json": file does not exist
* dir: open /var/tmp/podman3981212783/manifest.json: not a directory
make: *** [Makefile:160: container-build] Error 125
ohmsk:~/git/instana-public/instana-agent-operator (devenv-changes)$ podman ps
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
ohmsk:~/git/instana-public/instana-agent-operator (devenv-changes)$ podman ps -a
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
80fbc41aea46 docker.io/moby/buildkit:v0.16.0 4 weeks ago Exited (1) 43 hours ago buildkitdThere was a problem hiding this comment.
Please check operator-olm-build, I think you need to install kustomize here to work, probably with your make target.
This is probably also needed on the main pipeline for operator-olm-github-release
…ect level binaries and commit hooks
install-githookstarget that will be automatically called on install.make generate-deepcopiesto generate said files.