Skip to content

⚡ Bolt: Use stack allocation for status text in drawstatusbar #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paperbenni wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

⚡ Bolt: Use stack allocation for status text in drawstatusbar #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions bar.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,18 @@ int drawstatusbar(Monitor *m, int bh, char *stext) {
short isCode = 0;
char *text;
char *p;
/* Optimization: Use stack buffer for status text to avoid malloc overhead */
char buf[1024];
int use_malloc = 0;
Comment on lines +59 to +60
Copy link

@sourcery-ai sourcery-ai bot Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Consider aligning types and limits when comparing len to sizeof(buf).

Here sizeof(buf) is size_t while len is an int, which can trigger signed/unsigned comparison warnings and obscure overflow/limit issues. Please make len a size_t (matching strlen and sizeof(buf)), and then you can simply use malloc(len) instead of sizeof(char) * len.

Suggested implementation:

    short isCode = 0;
    char *text;
    char *p;
    /* Optimization: Use stack buffer for status text to avoid malloc overhead */
    char buf[1024];
    int use_malloc = 0;
    size_t len;

    len = strlen(stext) + 1;
    if (len > sizeof(buf)) {
        if (!(text = (char *)malloc(len))) {
            die("malloc");
        }
        use_malloc = 1;
    } else {
        text = buf;
    }

If len is declared elsewhere in this function or file (e.g., as int len;), that declaration should be updated to size_t len; and the duplicate declaration here removed to avoid redefinition errors.


len = strlen(stext) + 1;
if (!(text = (char *)malloc(sizeof(char) * len))) {
die("malloc");
if (len > sizeof(buf)) {
if (!(text = (char *)malloc(sizeof(char) * len))) {
die("malloc");
}
use_malloc = 1;
} else {
text = buf;
}
p = text;
memcpy(text, stext, len);
Expand Down Expand Up @@ -194,7 +202,9 @@ int drawstatusbar(Monitor *m, int bh, char *stext) {
}

drw_setscheme(drw, statusscheme);
free(p);
if (use_malloc) {
free(p);
}

return ret;
}
Expand Down