Skip to content

Conversation

@mitchelvanbever
Copy link
Member

This PR updates everything to the latest versions to fix any errors related to outdated package versions.

If you wanna test yourself but don't know how HMU 🤙

Notable changes for the BE:

  • Following rule has been removed @typescript-eslint/interface-name-prefix. I've replaced it as suggested but when testing in the BE it triggered a shit ton of errors (cc: @ggurkal)
  • Running the updated config ran some (weird) auto fixed issues with parenthesis (maybe there is something we need to add to the config).
  • One other "error" was shown that wasn't autofixed: Expected a const assertion instead of a literal type annotation @typescript-eslint/prefer-as-const but it gives the same typesafety and could be considered a little DRY'er IMO.

Still testing for the frontend. Will update this description when more info follows.

@ggurkal
Copy link
Member

ggurkal commented Feb 15, 2023

@mitchelvanbever Does the following part enforces not using the I prefix?

custom: {
          regex: '^I[A-Z]',
          match: false,
        },

@mitchelvanbever
Copy link
Member Author

@mitchelvanbever Does the following part enforces not using the I prefix?

custom: {
          regex: '^I[A-Z]',
          match: false,
        },

Yes that's what the link I've sent recommends doing to replace the removed rule ☺️

@ggurkal
Copy link
Member

ggurkal commented Feb 15, 2023

I think we should remove the custom part as the part we had (@typescript-eslint/interface-name-prefix) has the value never which doesn't force the I prefix.

@mitchelvanbever
Copy link
Member Author

I think we should remove the custom part as the part we had (@typescript-eslint/interface-name-prefix) has the value never which doesn't force the I prefix.

That's what this is doing as well. It's forcing you not to prefix with I. Did I apply the wrong rule?

@ggurkal
Copy link
Member

ggurkal commented Feb 15, 2023

I think we should remove the custom part as the part we had (@typescript-eslint/interface-name-prefix) has the value never which doesn't force the I prefix.

That's what this is doing as well. It's forcing you not to prefix with I. Did I apply the wrong rule?

The thing is, we currently don't force anything.

@mitchelvanbever
Copy link
Member Author

The thing is, we currently don't force anything.

Ah hehe I really thought we'd force to never prefix with I but it does explain the linter issues popping up when this rule is added. I'll remove it, from there nothing will be forced 🙂

@ggurkal
Copy link
Member

ggurkal commented Feb 15, 2023

The thing is, we currently don't force anything.

Ah hehe I really thought we'd force to never prefix with I but it does explain the linter issues popping up when this rule is added. I'll remove it, from there nothing will be forced 🙂

Yeah, mainly we don't prefix interfaces with I, unless they need to be implemented by a class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants