Skip to content

chore(metrics): send only new format for pipeline trigger metrics #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore(metrics): send only new format for pipeline trigger metrics #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 1 addition & 28 deletions pkg/utils/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const (
RenameEvent string = "Rename"
ExecuteEvent string = "Execute"

pipelineMeasurement = "pipeline.trigger.v1"
pipelineMeasurement = "pipeline.trigger"
)

func IsAuditEvent(eventName string) bool {
Expand Down Expand Up @@ -106,33 +106,6 @@ func NewPipelineDataPoint(data PipelineUsageMetricData) *write.Point {
return influxdb2.NewPoint(pipelineMeasurement, tags, fields, time.Now())
}

// DeprecatedNewPipelineDatapoint transforms the information of a pipeline
// triger into an InfluxDB datapoint. This measurement is deprecated and will
// be retired with the new dashboard implementation.
func DeprecatedNewPipelineDatapoint(data PipelineUsageMetricData) *write.Point {
return influxdb2.NewPoint(
"pipeline.trigger",
map[string]string{
"status": data.Status.String(),
"trigger_mode": data.TriggerMode.String(),
},
map[string]any{
"owner_uid": data.OwnerUID,
"owner_type": data.OwnerType,
"user_uid": data.UserUID,
"user_type": data.UserType,
"pipeline_id": data.PipelineID,
"pipeline_uid": data.PipelineUID,
"pipeline_release_id": data.PipelineReleaseID,
"pipeline_release_uid": data.PipelineReleaseUID,
"pipeline_trigger_id": data.PipelineTriggerUID,
"trigger_time": data.TriggerTime,
"compute_time_duration": data.ComputeTimeDuration,
},
time.Now(),
)
}

type ConnectorUsageMetricData struct {
OwnerUID string
OwnerType mgmtPB.OwnerType
Expand Down
1 change: 0 additions & 1 deletion pkg/worker/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ func (w *worker) writeNewDataPoint(ctx context.Context, data utils.PipelineUsage
}

w.influxDBWriteClient.WritePoint(utils.NewPipelineDataPoint(data))
w.influxDBWriteClient.WritePoint(utils.DeprecatedNewPipelineDatapoint(data))

return nil
}
Expand Down
Loading