Add custom start week to date picker #5
Conversation
| days-to-fill (range (inc (- last-day (dec weekday-current-month))) (inc last-day))] | ||
| days-to-fill (range (inc | ||
| (- last-day | ||
| (case week-start |
There was a problem hiding this comment.
que problema le ves a esto?
There was a problem hiding this comment.
mm te referis al uso de case? o notas un bug en el calculo?
There was a problem hiding this comment.
si es por el case, no tiene valor por default lo que causario un error por el nil. No se lo agregue porque la funcion principal ya tiene un default con el :or. Pero podria agregarse para hacerlo mas robusto supongo
There was a problem hiding this comment.
claro, si paso nil va a funcionar, pero si paso algo que no es :sunday o :monday va a reventar, yo esperaría o que defaultea a :monday que es el 90% de los casos, o que directamente te avise que la inicialización está mal y que los valores esperados son :monday :sunday (usar otra cosa ya es extremadamente raro)
| weekday-current-month (time/day-of-week current-month) | ||
| previous-month (time/minus current-month (time/months 1)) | ||
| (defn- build-previous-month-days [date week-start] | ||
| (let [current_month (time/month date) |
There was a problem hiding this comment.
ojo que snake case no se usa en clj
| (= input-format "integer") "right" | ||
| (= input-format "currency") "right" | ||
| :else "left"))}))})) | ||
| (let [valid-date-formats #{"MM/dd/yyy" "dd/MM/yyyy"}] |
There was a problem hiding this comment.
particularmente creo que llevaría este let más cerca de donde se usa y no en la raíz del componente (porque en general algo a ese nivel asumimos que va a ser usado por todos lados pero no es el caso)
There was a problem hiding this comment.
sisi, es verdad, podria moverse tranquilamente a la llave :date-format
Preliminary steps
The following are some of the steps I made to have the repo working on my machine... (ignore them if you are only interested in the implementation itself):
Error running
lein figwheel basic:Exception in thread "main" java.lang.ClassNotFoundException: javax.xml.bind.DatatypeConverter, compiling:(cljs/closure.clj:1:1)
Caused by: java.lang.ClassNotFoundException: javax.xml.bind.DatatypeConverter
Diagnostic:
The class doesn't exsist in modern java versions
Ask current java version:
~/Desktop/clojure/om-widgets> java -version
openjdk version "18.0.1.1" 2022-04-22
OpenJDK Runtime Environment (build 18.0.1.1+2-6)
OpenJDK 64-Bit Server VM (build 18.0.1.1+2-6, mixed mode, sharing)
Required version by repo: < 9
Install sdk for java version management
~/Desktop/clojure/om-widgets> curl -s "https://get.sdkman.io" | bash
~/Desktop/clojure/om-widgets> source "/Users/fabriciocozzarolo/.sdkman/bin/sdkman-init.sh"
Install and use required version
~/Desktop/clojure/om-widgets> sdk install java 8.0.452-librca
Check current version
~/Desktop/clojure/om-widgets> sdk current java
Using java version 8.0.452-librca
Error running
lein figwheel basic:Exception in thread "main" java.io.FileNotFoundException: Could not locate clojure/tools/nrepl/server__init.class or clojure/tools/nrepl/server.clj on classpath., compiling:(figwheel_sidecar/repl.clj:1:1)
Caused by: java.io.FileNotFoundException: Could not locate clojure/tools/nrepl/server__init.class or clojure/tools/nrepl/server.clj on classpath.
Diagnostic
Missing dependency in classpath
Solution
Add dependency to project.clj in :dependencies key [...
[org.clojure/tools.nrepl "0.2.13"]
...]
Page not found in browser
Documentation at readme file suggested navigating to localhost:3449 but figwheel server port was actually configured at
3450 in project.clj config file
Summary of changes:
Tester info
Datpicker:
Textinput: