BENB scale endless velocity to its previous range#145
Conversation
Test Result:This PR fixes the Endless issue: Firmware Roadmap (view) The Endless Velocity is consistent. minor bug: |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| } | ||
|
|
||
| uint8_t grid_ui_endless_update_trigger(struct grid_ui_element* ele, int stabilized, int16_t delta, uint64_t* endless_last_real_time, double* delta_vel_frac) { | ||
| uint8_t grid_ui_endless_update_trigger(struct grid_ui_element* ele, int stabilized, int16_t delta, uint64_t* endless_last_real_time, double* delta_frac) { |
There was a problem hiding this comment.
✅ Getting better: Complex Method
grid_ui_endless_update_trigger decreases in cyclomatic complexity from 21 to 20, threshold = 9
| if (update) { | ||
| old_value->phase_a = new_value->phase_a; | ||
| old_value->phase_b = new_value->phase_b; | ||
| } |
There was a problem hiding this comment.
✅ No longer an issue: Complex Method
grid_ui_endless_store_input is no longer above the threshold for cyclomatic complexity
| if (update) { | ||
| old_value->phase_a = new_value->phase_a; | ||
| old_value->phase_b = new_value->phase_b; | ||
| } |
There was a problem hiding this comment.
✅ No longer an issue: Bumpy Road Ahead
grid_ui_endless_store_input is no longer above the threshold for logical blocks with deeply nested code
| } | ||
|
|
||
| uint8_t grid_ui_endless_update_trigger(struct grid_ui_element* ele, int stabilized, int16_t delta, uint64_t* endless_last_real_time, double* delta_vel_frac) { | ||
| uint8_t grid_ui_endless_update_trigger(struct grid_ui_element* ele, int stabilized, int16_t delta, uint64_t* endless_last_real_time, double* delta_frac) { |
There was a problem hiding this comment.
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 6.43 to 6.14, threshold = 4
Test passedMinor bug fixed |
3 participants
No description provided.