SUKU self:draw_pixel and LCD indexing implemented#147
Merged
benblaise-intech merged 16 commits intomasterfrom Feb 10, 2025
Merged
SUKU self:draw_pixel and LCD indexing implemented#147benblaise-intech merged 16 commits intomasterfrom
benblaise-intech merged 16 commits intomasterfrom
Conversation
|
|
||
| int x = luaL_checknumber(L, 1); | ||
| int y = luaL_checknumber(L, 2); | ||
| int screen_index = luaL_checknumber(L, 1); |
There was a problem hiding this comment.
✅ Getting better: Code Duplication
reduced similar code in: l_grid_gui_draw_pixel
Member
Author
Limitation
Encoder specific change
Global function change
LCD element specific changes
|
Contributor
|
GUI changes work as expected. Unable to upload FW to modules with encoders, not possible to test. When attempting to upload, after FW boots purple flashing is observed. |
…into SUKU-gui-api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.