Skip to content

SUKU self:draw_pixel and LCD indexing implemented#147

Merged
benblaise-intech merged 16 commits intomasterfrom
SUKU-gui-api
Feb 10, 2025
Merged

SUKU self:draw_pixel and LCD indexing implemented#147
benblaise-intech merged 16 commits intomasterfrom
SUKU-gui-api

Conversation

@SukuWc
Copy link
Member

@SukuWc SukuWc commented Jan 30, 2025

No description provided.

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (8.93 -> 8.93)

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (8.93 -> 8.93)

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.06 (7.25 -> 7.31)

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.06 (7.25 -> 7.31)

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.06 (7.25 -> 7.31)

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.02 (7.25 -> 7.27)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene


int x = luaL_checknumber(L, 1);
int y = luaL_checknumber(L, 2);
int screen_index = luaL_checknumber(L, 1);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Getting better: Code Duplication
reduced similar code in: l_grid_gui_draw_pixel

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.02 (7.25 -> 7.27)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

@SukuWc
Copy link
Member Author

SukuWc commented Jan 31, 2025

Limitation

  • This is only API prototype for evaluation
  • self based Led color is only implement on encoder element
  • screen selection is only placeholder, in this code only a single framebuffer is allocated
  • automatic screen selection is also not implemented, just placeholder

Encoder specific change

  • on encoder element now setting color is available via self:elc(layer, 255,0,0)

Global function change

  • draw pixel fixed, now first argument sets lcd index: test with new short name ggdpx(1, x, y,{r,g,b})

LCD element specific changes

  • self:element_index() should return proper element index
  • self:lin() should return lcd index
  • self:lsw() should return screen width
  • self:lsh() should return screen height
  • self:ldp(x,y,{r,g,b}) should draw pixel to automatically selected screen

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.02 (7.25 -> 7.27)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

@narayb
Copy link
Contributor

narayb commented Jan 31, 2025

GUI changes work as expected.

Unable to upload FW to modules with encoders, not possible to test. When attempting to upload, after FW boots purple flashing is observed.

@benblaise-intech benblaise-intech self-assigned this Feb 7, 2025
@SukuWc SukuWc changed the title SUKU self:draw_pixel implemented SUKU self:draw_pixel and LCD indexing implemented Feb 9, 2025
@benblaise-intech benblaise-intech merged commit fdf6ae5 into master Feb 10, 2025
8 checks passed
@Greg-Orca Greg-Orca mentioned this pull request Mar 28, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants