Conversation
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
SukuWc
left a comment
SukuWc
left a comment
There was a problem hiding this comment.
Changes look comprehensive, overall quality and style matches the standards of the code base, please consider implementing the minor possible improvements mentioned in the comments!
| uint8_t a; | ||
| }; | ||
|
|
||
| #define grid_unpack_rgba(color) \ |
There was a problem hiding this comment.
Why is this not a function?
There was a problem hiding this comment.
grid_gui_lua_draw_demo should exercise the lua api instead of just calling draw demo. It is important because this can throw error if there were incompatible API changes!
There was a problem hiding this comment.
I understand that this change was necessary for graphics demos but must be reverted before merging to master!
There was a problem hiding this comment.
I understand that this change was necessary for graphics demos but must be reverted before merging to master!
| GRID_LCD_CLK_COUNT, | ||
| }; | ||
|
|
||
| struct grid_esp32_lcd_model { |
There was a problem hiding this comment.
Can we refactor to have two instances of esp32_lcd_model instead of making every member variable an array to support multiple screens?
|
|
||
| esp_lcd_panel_handle_t handle = lcd->panel[lcd_index][GRID_LCD_CLK_FAST]; | ||
|
|
||
| gpio_set_level(lcd->cs_gpio_num[lcd_index], 0); |
There was a problem hiding this comment.
It would be nice to create a wrapper function for activating and deactivating an lcd, instead of raw GPIO calls
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
2 participants
No description provided.