Replace IDF base image with bare Debian, remove CodeQL, fix GCC 14 build errors#309
Open
Replace IDF base image with bare Debian, remove CodeQL, fix GCC 14 build errors#309
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…F v5.5 install Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…patibility Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… callback type mismatches, remove unused variable Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… emscripten Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…n D51 build Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
espressif/idf:v5.5) with baredebian:trixie+ manual ESP-IDF v5.5 installation, scoped toesp32s3only for a smaller imagecodeql_intech.yml), helper script (fail_on_error.py), and.gitignoreCONFIG_BOOT_ROM_LOG_ON_GPIO_HIGH=yin sdkconfig triggers an ESP-IDF bug that crashes on boot when the eFuse is already burned — the IDF startup code handlesESP_ERR_NOT_SUPPORTEDbut notESP_ERR_INVALID_STATE. The fix was reportedly merged upstream but never made it to the main branch. Instead of patching IDF source in Docker, we now set sdkconfig toCONFIG_BOOT_ROM_LOG_ALWAYS_ON=y(default) and callesp_efuse_set_rom_log_scheme(ESP_EFUSE_ROM_LOG_ON_GPIO_HIGH)directly in firmware with proper error handling for all return codes. Thepatch_esp_efuse_startup.shDocker patch is removed.gcc-arm-none-eabi14.2):#include <assert.h>across 10 files ingrid_common/#include <stdlib.h>ingrid_transport.c,grid_port.c,grid_config.c#include <stdio.h>instartup_samd51.c,grid_d51_usb.cgrid_d51.h,grid_d51_uart.h,grid_d51_usb.h,grid_module.h,usb_start.h)i2c_m_async_transfer,_dma_set_source_address,hiddf_keyboard_keys_state_change,adc_async_read_channel, callback signatures for ADC and SPIGRID_D51_USER_ROW_BASEint-to-pointer casttx_cb_USART_GRID,dma_transfer_completevolatile dmatestmissing type specifiergrid_cal_nextmissing return statementgrid_led_startup_animationextra address-of operatorluaL_Reginitializer missing bracesRUNinto separate layers, useapt-getinstead ofaptfor non-interactive compatibilitypatch_esp_trace_include.shto use$IDF_PATHwith guard check instead of hardcoded/opt/esp/idf/emcmake cmakefor proper Emscripten toolchain setupTesting
Docker image
--no-cache)gcc-arm-none-eabi,emcc, andidf.pyare available in containerFirmware builds
d51_build_firmware.sh)esp_build_firmware.sh)pico_build_firmware.sh)gui_build.sh)ROM log workaround with fresh boards
ROM log workaround with known incorrectly configured boards