features/eu-debug: check attention bits only once in attention_scan_fn() #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbommu
reviewed
Jan 6, 2026
| The fix consolidates attention checking to a single point in | ||
| attention_scan_fn(), ensuring atomic decision making for both event types. | ||
|
|
||
| Signed-off-by: Jan Maslak <jan.maslak@intel.com> |
There was a problem hiding this comment.
can please add source details like
(cherry-picked from commit e6c8720d978831b669c4763ddeecda14fca13ed3 xe internal)
or
(backported from commit d41f306cc2e3cc44b1226122d97bf3d451c9c6e6 linux-next)
Previously, handle_gt_queued_pagefault() and xe_eudebug_handle_gt_attention() each performed separate attention bit checks. This created a race window where attention bits could change between the two checks, leading to inconsistent event delivery. The fix consolidates attention checking to a single point in attention_scan_fn(), ensuring atomic decision making for both event types. Signed-off-by: Jan Maslak <jan.maslak@intel.com>
cladur
force-pushed
the
6.17_atomic_attention_scan_fixup
branch
from
a5fcddd to
2677c08
Compare
Author
|
@kbommu Added a line referencing the source details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new eu-debug patch that makes the attention bits be checked only once during attention scan.
Previously, handle_gt_queued_pagefault() and xe_eudebug_handle_gt_attention() each performed separate attention bit checks. This created a race window where attention bits could change between the two checks, leading to inconsistent event delivery.
The fix consolidates attention checking to a single point in attention_scan_fn(), ensuring atomic decision making for both event types.