Skip to content

Conversation

@pravalikagurram1
Copy link

[ Backport to fix use-after-free crash during driver unload ]

Backport upstream changes to fix a use-after-free crash in
xe_migrate_fini during driver unload. The issue occurs when
xe_migrate_fini is called during drm_managed_release and attempts
to access GGTT resources that have already been freed.i

Fix: Switch from drmm_add_action_or_reset to devm_add_action_or_reset
to ensure xe_migrate_fini runs before underlying device resources are
torn down. Also remove unused drm_device parameter.

This backport is needed to prevent system crashes during driver
unload/device removal scenarios.

Signed-off-by: Pravalika Gurram pravalika.gurram@intel.com

@sys-i915-oscijenkins
Copy link

CI Bug Log - changes from xkb-6.14-198-0db7ec117573b2944f4ca001e591a52931c92271_BAT -> xkb-pr-6.14-244-426-37ac3b586116bb5284b36717b7d797df7c28f840_BAT

Summary

SUCCESS

No regressions found.

Participating hosts (5 -> 5)

No changes in participating hosts

Known issues

Here are the changes found in xkb-pr-6.14-244-426-37ac3b586116bb5284b36717b7d797df7c28f840_BAT that come from known issues:

IGT changes

Issues hit

Warnings

Build changes

  • IGT: igt-xkb-92-165f8a8a8 -> igt-xkb-94-165f8a8a8
  • Linux: xkb-6.14-198-0db7ec117573b2944f4ca001e591a52931c92271 -> xkb-pr-6.14-244-426-37ac3b586116bb5284b36717b7d797df7c28f840

igt-xkb-92-165f8a8a8: 165f8a8a8
igt-xkb-94-165f8a8a8: 165f8a8a8
xkb-6.14-198-0db7ec117573b2944f4ca001e591a52931c92271: 0db7ec1
xkb-pr-6.14-244-426-37ac3b586116bb5284b36717b7d797df7c28f840: 37ac3b5

backport/patches/features/sriov/0001-drm-xe-Protect-against-unset-LRC-when-pausing-submis.patch
backport/patches/features/sriov/0001-drm-xe-vf-Start-re-emission-from-first-unsignaled-jo.patch
backport/patches/features/sriov/0001-drm-xe-vf-Stop-waiting-for-ring-space-on-VF-post-mig.patch
backport/patches/features/sriov/0001-drm-xe-migrate-Switch-from-drm-to-dev-managed-action.patch
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this patch was added to the 'sriov' section?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All dependent patches are located in the sriov folder. These dependencies were
originally backported as part of the SR-IOV work, hence their placement in the
sriov directory. Given these dependencies, this patch is now included as part
of the SR-IOV patch series.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pravalikagurram1 / @mwajdecz the changes are added as dependencies as part of sriov feature backport and they were only required for SRIOV at that time. I agree on the term that it should be part of base. But 6.14 currently is reaching EoL by EoM. So we will proceed further with the current approach. However, we will movements in 6.17 branch if and as needed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base Section:
Used for patches that need to be included in both HWE (Hardware Enablement) and -intel (PPA) kernels. These are foundational patches required across different kernel distributions.

Feature Sections:
Used to enable specific features that are not part of the base kernel. Each feature section is self-contained and includes all necessary dependencies within the same section.

Important Note:
Feature sections (e.g., feature/xyz) may contain additional dependencies as needed to support the feature implementation. This modular approach ensures features can be enabled independently with their complete dependency chain.

@mwajdecz

@sys-i915-oscijenkins
Copy link

CI Bug Log - changes from xkb-6.14-201-6a9cd870196dd5093cc5938ef5e85a2306d5c523_BAT -> xkb-pr-6.14-244-431-317419b5653949e3fc39b848b0a8cb496c11a922_BAT

Summary

FAILURE

Serious unknown changes coming with xkb-pr-6.14-244-431-317419b5653949e3fc39b848b0a8cb496c11a922_BAT absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in xkb-pr-6.14-244-431-317419b5653949e3fc39b848b0a8cb496c11a922_BAT, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.

Participating hosts (5 -> 5)

No changes in participating hosts

Possible new issues

Here are the unknown changes that may have been introduced in xkb-pr-6.14-244-431-317419b5653949e3fc39b848b0a8cb496c11a922_BAT:

IGT changes

Possible regressions

Known issues

Here are the changes found in xkb-pr-6.14-244-431-317419b5653949e3fc39b848b0a8cb496c11a922_BAT that come from known issues:

IGT changes

Issues hit

Build changes

  • IGT: igt-xkb-94-165f8a8a8 -> igt-xkb-95-a3eb9cd4d
  • Linux: xkb-6.14-201-6a9cd870196dd5093cc5938ef5e85a2306d5c523 -> xkb-pr-6.14-244-431-317419b5653949e3fc39b848b0a8cb496c11a922

igt-xkb-94-165f8a8a8: 165f8a8a8
igt-xkb-95-a3eb9cd4d: a3eb9cd4d
xkb-6.14-201-6a9cd870196dd5093cc5938ef5e85a2306d5c523: 6a9cd87
xkb-pr-6.14-244-431-317419b5653949e3fc39b848b0a8cb496c11a922: 317419b

Backport to fix use-after-free crash during driver unload

Backport upstream changes to fix a use-after-free crash in
xe_migrate_fini during driver unload. The issue occurs when
xe_migrate_fini is called during drm_managed_release and attempts
to access GGTT resources that have already been freed.i

Fix: Switch from drmm_add_action_or_reset to devm_add_action_or_reset
to ensure xe_migrate_fini runs before underlying device resources are
torn down. Also remove unused drm_device parameter.

This backport is needed to prevent system crashes during driver
unload/device removal scenarios.

Signed-off-by: Pravalika Gurram <pravalika.gurram@intel.com>
@sys-i915-oscijenkins
Copy link

CI Bug Log - changes from xkb-6.14-201-6a9cd870196dd5093cc5938ef5e85a2306d5c523_BAT -> xkb-pr-6.14-244-432-317419b5653949e3fc39b848b0a8cb496c11a922_BAT

Summary

FAILURE

Serious unknown changes coming with xkb-pr-6.14-244-432-317419b5653949e3fc39b848b0a8cb496c11a922_BAT absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in xkb-pr-6.14-244-432-317419b5653949e3fc39b848b0a8cb496c11a922_BAT, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.

Participating hosts (5 -> 5)

No changes in participating hosts

Possible new issues

Here are the unknown changes that may have been introduced in xkb-pr-6.14-244-432-317419b5653949e3fc39b848b0a8cb496c11a922_BAT:

IGT changes

Possible regressions

Known issues

Here are the changes found in xkb-pr-6.14-244-432-317419b5653949e3fc39b848b0a8cb496c11a922_BAT that come from known issues:

IGT changes

Issues hit

Build changes

  • IGT: igt-xkb-94-165f8a8a8 -> igt-xkb-95-a3eb9cd4d
  • Linux: xkb-6.14-201-6a9cd870196dd5093cc5938ef5e85a2306d5c523 -> xkb-pr-6.14-244-432-317419b5653949e3fc39b848b0a8cb496c11a922

igt-xkb-94-165f8a8a8: 165f8a8a8
igt-xkb-95-a3eb9cd4d: a3eb9cd4d
xkb-6.14-201-6a9cd870196dd5093cc5938ef5e85a2306d5c523: 6a9cd87
xkb-pr-6.14-244-432-317419b5653949e3fc39b848b0a8cb496c11a922: 317419b

@sys-i915-oscijenkins
Copy link

CI Bug Log - changes from xkb-6.14-201-6a9cd870196dd5093cc5938ef5e85a2306d5c523_BAT -> xkb-pr-6.14-244-433-c7e1c1228bf8684930fdd1f054cd6ea330aaecb7_BAT

Summary

FAILURE

Serious unknown changes coming with xkb-pr-6.14-244-433-c7e1c1228bf8684930fdd1f054cd6ea330aaecb7_BAT absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in xkb-pr-6.14-244-433-c7e1c1228bf8684930fdd1f054cd6ea330aaecb7_BAT, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.

Participating hosts (5 -> 5)

No changes in participating hosts

Possible new issues

Here are the unknown changes that may have been introduced in xkb-pr-6.14-244-433-c7e1c1228bf8684930fdd1f054cd6ea330aaecb7_BAT:

IGT changes

Possible regressions

Known issues

Here are the changes found in xkb-pr-6.14-244-433-c7e1c1228bf8684930fdd1f054cd6ea330aaecb7_BAT that come from known issues:

IGT changes

Issues hit

Build changes

  • IGT: igt-xkb-94-165f8a8a8 -> igt-xkb-95-a3eb9cd4d
  • Linux: xkb-6.14-201-6a9cd870196dd5093cc5938ef5e85a2306d5c523 -> xkb-pr-6.14-244-433-c7e1c1228bf8684930fdd1f054cd6ea330aaecb7

igt-xkb-94-165f8a8a8: 165f8a8a8
igt-xkb-95-a3eb9cd4d: a3eb9cd4d
xkb-6.14-201-6a9cd870196dd5093cc5938ef5e85a2306d5c523: 6a9cd87
xkb-pr-6.14-244-433-c7e1c1228bf8684930fdd1f054cd6ea330aaecb7: c7e1c12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants