Single source for maximum frequency #591
Merged
+2
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes all references to the
maximum frequencyscript from the codebase, simplifying the way maximum core frequency is determined and reported. The logic for retrieving the maximum frequency now relies solely on MSR/TPMI data, and the fallback to other sources such as/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freqor dmidecode has been eliminated.Key changes include:
Removal of
maximum frequencyscript:MaximumFrequencyScriptNameconstant and its associated script definition frominternal/script/script_defs.go. [1] [2]script.MaximumFrequencyScriptNamefrom the list of scripts incmd/report/report_tables.goandinternal/common/table_defs.go. [1] [2]Refactoring of maximum frequency retrieval logic:
MaxFrequencyFromOutputfunction ininternal/common/frequency.goto remove logic that used/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freqand dmidecode as sources for the maximum frequency, now relying only on MSR/TPMI data. [1] [2]