Skip to content

refactor: replaced push to emplace C++11 for stl containers #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: replaced push to emplace C++11 for stl containers #792

wants to merge 1 commit into from

Conversation

GermanAizek
Copy link
Contributor

No description provided.

@JablonskiMateusz
Copy link
Contributor

What is motivation for this change?

emplace causes issues with some compilers. Even recently we switched one emplace to insert 1110410

@GermanAizek
Copy link
Contributor Author

What is motivation for this change?

The motivation is completely identical to this PR: intel/media-driver#1875 (comment)
In some compilers, it has little effect on insertion elements speed, and it's also just more beautiful and modern C++.

@GermanAizek
Copy link
Contributor Author

emplace causes issues with some compilers. Even recently we switched one emplace to insert 1110410

@JablonskiMateusz, Ok thanks for more detailed info.
I revert replace changes described in this commit.

@GermanAizek
Copy link
Contributor Author

@JablonskiMateusz, regress changes from 1110410 not on my PR commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GermanAizek @JablonskiMateusz