Skip to content

[CI][sglang] Add benchmark from sglang #5341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 31, 2025
Merged

[CI][sglang] Add benchmark from sglang #5341

merged 14 commits into from
Oct 31, 2025

Conversation

@Egor-Krivov
Copy link
Contributor

@Egor-Krivov Egor-Krivov commented Oct 17, 2025 •
edited
Loading

This is one of the key workloads provided by sglang team, I locally optimized code with tensor descriptor as an example for them.

@Egor-Krivov Egor-Krivov marked this pull request as draft October 17, 2025 16:11
@Egor-Krivov Egor-Krivov marked this pull request as ready for review October 20, 2025 12:37
@Egor-Krivov
Copy link
Contributor Author

Test run https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/18652243529

@Egor-Krivov
Copy link
Contributor Author

Test run with benchmarks:
https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/18882197309

Test run with tests:
https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/18816467016/job/53685540709

@Egor-Krivov
Copy link
Contributor Author

I added sglang pin and usage of sglang kernel for comparison

@Egor-Krivov Egor-Krivov enabled auto-merge (squash) October 29, 2025 11:17
@Egor-Krivov
Copy link
Contributor Author

@etiotto @whitneywhtsang Ready to merge

whitneywhtsang
whitneywhtsang approved these changes Oct 31, 2025
View reviewed changes
benchmarks/third_party/sglang/scaled_mm_benchmark.py
# eventually occur.

# Offsets and masks.
# offsets_am = pid_m * BLOCK_SIZE_M + tl.arange(0, BLOCK_SIZE_M).to(tl.int64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you prefer to keep the regular pointer code as comments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference

@Egor-Krivov Egor-Krivov merged commit 37bc4ad into main Oct 31, 2025
26 of 28 checks passed
@Egor-Krivov Egor-Krivov deleted the egor/sglang_bench branch October 31, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whitneywhtsang whitneywhtsang whitneywhtsang approved these changes

@anmyachev anmyachev Awaiting requested review from anmyachev

@kwasd kwasd Awaiting requested review from kwasd

@etiotto etiotto Awaiting requested review from etiotto

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Egor-Krivov @whitneywhtsang @etiotto