Skip to content

Fix(llm-cli): Ensure script exits after displaying help message #13329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix(llm-cli): Ensure script exits after displaying help message #13329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions python/llm/src/ipex_llm/cli/llm-cli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,7 @@ while [[ $# -gt 0 ]]; do
case "$1" in
-h | --help)
display_help
filteredArguments+=("'$1'")
shift
exit 0
;;
-x | --model_family | --model-family)
model_family="$2"
Expand Down
11 changes: 11 additions & 0 deletions python/llm/test/cli/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import subprocess
import os

def test_llm_cli_help_fix():
"""
Tests that the llm-cli script exits gracefully after the fix.
"""
cli_path = os.path.abspath(os.path.join(os.path.dirname(__file__), '../../src/ipex_llm/cli/llm-cli'))
result = subprocess.run([cli_path, "--help"], capture_output=True, text=True)
assert "Invalid model_family" not in result.stdout
assert result.returncode == 0