media: i2c: ov01a1s: Change output size to 1288x800 #395
+10
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the output size to 1288x800 to match the maximum output width of the mainline ov01a1s support from (the mainline code keeps a 4x4 border reserved to be able to shift the window around to keep the Bayer pattern unchanged when doing flipping): https://lore.kernel.org/linux-media/20251014174033.20534-1-hansg@kernel.org/ and to change the height to be a multiple of 4, like the mainline support, since the RGBI Bayer patern on this sensor repeats every 4 lines. This requires a matching change to the following 2 files in ipu6-camera-hal: config/linux/ipu6/sensors/ov01a1s-uf.xml config/linux/ipu6/gcss/graph_settings_ov01a1s.xml I will submit a separate pull-request for the matching ipu6-camera-hal changes. Merging this change as well as the matching ipu6-camera-hal changes ensures that the ipu6-camera-hal + icamerasrc solution will keep working once ov01a1s support lands in the mainline kernel. This has been tested on a Dell Latitude 9420. Signed-off-by: Hans de Goede <hansg@kernel.org>
jwrdegoede
pushed a commit
to jwrdegoede/ipu6-camera-hal
that referenced
this pull request
Oct 28, 2025
…ernel driver output size There is a patch series pending upstream: https://lore.kernel.org/linux-media/20251014174033.20534-1-hansg@kernel.org/ To add ov01a1s support to the mainline kernel. The mainline support will have a slightly different output-size with a maximum output width of 1288 as the mainline code keeps a 4x4 border reserved to be able to shift the window around to keep the Bayer pattern unchanged when doing flipping. And with the mainline driver the output height must be a multiple of 4 because the RGBI Bayer patern on the ov01a1s sensor repeats every 4 lines. There also is a pending pull-request to change the output-size of the ov01a1s driver in intel-ipu6-drivers to match the mainline driver: intel/ipu6-drivers#395 This commit adjusts the graph_settings_ov01a1s.xml and ov01a1s-uf.xml config files to work with the new 1288x800 output size. Signed-off-by: Hans de Goede <hansg@kernel.org>
Contributor
Author
|
The matching ipu6-camera-hal pull-request with updates to graph_settings_ov01a1s.xml and ov01a1s-uf.xml to work with the new 1288x800 output size is available here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the output size to 1288x800 to match the maximum output width of the mainline ov01a1s support from (the mainline code keeps a 4x4 border reserved to be able to shift the window around to keep the Bayer pattern unchanged when doing flipping):
https://lore.kernel.org/linux-media/20251014174033.20534-1-hansg@kernel.org/
and to change the height to be a multiple of 4, like the mainline support, since the RGBI Bayer patern on this sensor repeats every 4 lines.
This requires a matching change to the following 2 files in ipu6-camera-hal:
config/linux/ipu6/sensors/ov01a1s-uf.xml
config/linux/ipu6/gcss/graph_settings_ov01a1s.xml
I will submit a separate pull-request for the matching ipu6-camera-hal changes.
Merging this change as well as the matching ipu6-camera-hal changes ensures that the ipu6-camera-hal + icamerasrc solution will keep working once ov01a1s support lands in the mainline kernel.
This has been tested on a Dell Latitude 9420.