Skip to content

Conversation

@vicamo
Copy link
Contributor

@vicamo vicamo commented Dec 16, 2025

v6.18-rc1 commit 5195b777552d2 ("media: v4l2-subdev: Make struct v4l2_subdev_stream_config private") stripped the use of v4l2_subdev_stream_config from the public. The "solution" should be same v6.18-rc1 commit 49cec2b5a316c (media: staging/ipu7: Disallow source multiplexing") that removed the use of stream_configs due to stream multiplexing.

drivers/media/pci/intel/ipu7/ipu7-isys-video.c: In function 'get_remote_pad_stream':
drivers/media/pci/intel/ipu7/ipu7-isys-video.c:884:55: error: invalid use of undefined type 'struct v4l2_subdev_stream_config'
  884 |                         &state->stream_configs.configs[i];
      |                                                       ^
drivers/media/pci/intel/ipu7/ipu7-isys-video.c:885:24: error: invalid use of undefined type 'struct v4l2_subdev_stream_config'
  885 |                 if (cfg->pad == r_pad->index) {
      |                        ^~
drivers/media/pci/intel/ipu7/ipu7-isys-video.c:886:40: error: invalid use of undefined type 'struct v4l2_subdev_stream_config'
  886 |                         stream_id = cfg->stream;
      |                                        ^~
make[5]: *** [/usr/src/linux-headers-6.18.0-9003-generic/scripts/Makefile.build:287: drivers/media/pci/intel/ipu7/ipu7-isys-video.o] Error 1

The IPU7 ISYS driver can't capture multiple streams on the same video
device. Disallow source multiplexing in the routes of the internal
subdev to reflect that limitation. As a result we can hardcode the
source stream to 0, simplifying the driver.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
Bug-Ubuntu: https://bugs.launchpad.net/bugs/2130334
Origin: backport, https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=49cec2b5a316ce2669e17ce1d458a8dfc1157f09
Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants