[SYCL] Remove logical_or and logical_and from group algorithm tests#18411
Merged
AlexeySachkov merged 20 commits intointel:syclfrom Oct 30, 2025
Merged
[SYCL] Remove logical_or and logical_and from group algorithm tests#18411AlexeySachkov merged 20 commits intointel:syclfrom
logical_or and logical_and from group algorithm tests#18411AlexeySachkov merged 20 commits intointel:syclfrom
Conversation
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@aelovikov-intel Please, could you review again? |
aelovikov-intel
changed the title
logical_or and logical_and from group algorithm tests
sycl/test-e2e/GroupAlgorithm/logical_or_and_group_algorithms.cpp
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,174 @@ | |||
| // RUN: %clangxx -fsycl -Xclang -verify=expected -fpreview-breaking-changes -fsyntax-only -ferror-limit=0 %s | |||
Contributor
There was a problem hiding this comment.
That file should go to sycl/test, not sycl/test-e2e. You'd also be able to simplify the test by doing device compilation only and avoiding all the queue/submit/handler/etc. Check existing negative tests there.
Contributor
There was a problem hiding this comment.
You'd also be able to simplify the test by doing device compilation only and avoiding all the queue/submit/handler/etc. Check existing negative tests there.
How exactly is this
Done, thanks
?
Contributor
Author
There was a problem hiding this comment.
@aelovikov-intel Sorry, forgot about it. Reworked to avoid queues, submit etc.
sycl/test-e2e/GroupAlgorithm/logical_or_and_group_algorithms.cpp
Outdated
Show resolved
Hide resolved
dklochkov-emb
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@aelovikov-intel Please, take a look |
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Oct 30, 2025
Contributor
|
This PR only changed tests, so the following failure is unrelated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fixes tests
SYCL :: GroupAlgorithm/exclusive_scan_sycl2020.cpp
SYCL :: GroupAlgorithm/inclusive_scan_sycl2020.cpp
SYCL :: GroupAlgorithm/reduce_sycl2020.cpp
due to becoming invalid in case of binary_op is logical_or and logical_and.
Spec has Mandates for each group algorithm which tells that binary_op:
binary_op(init, *first) must return a value of type T.
etc. but logical_or and logical_and in ABI breaking mode has return type boolean