[CI][SYCL][Test] Add CMake target for running SYCL unit tests with ABI breaking changes enabled #19687

uditagarwal97 · 2025-08-01T20:49:08Z

This PR adds a new CMake target check-sycl-unittests-preview that enabled running SYCL unittests with preview breaking changes enabled.

…eaking changes enabled.

aelovikov-intel · 2025-08-04T15:28:06Z

sycl/cmake/modules/AddSYCLUnitTestPreview.cmake

+#
+# Will compile the list of files together and link against SYCL.
+# Produces a binary names `basename(test_dirname)`.
+macro(add_sycl_unittest_preview test_dirname link_variant)


I'd expect preview and non-preview versions have a lot of similarities. Is it possible to have

define/macro/whatever add_sycl_unittest_impl(bool IsPreview, ...) { ... } define/macro/whatever add_sycl_unittest(...) { add_sycl_unittest_impl(true, ...) add_sycl_unittest_impl(false, ...) }

Or just have them both processed in one go in a single routine if that can work (some loop maybe?)

Yes, I'm separating out all the common functionality into a different macro.

Copilot

Pull Request Overview

This PR adds a new CMake target check-sycl-unittests-preview that enables running SYCL unit tests with preview breaking changes enabled, allowing testing of code paths that use the __INTEL_PREVIEW_BREAKING_CHANGES preprocessor macro.

Key changes:

Introduces add_sycl_unittest_both macro to create both regular and preview versions of tests
Updates all SYCL unit test CMakeLists.txt files to use the new macro
Adds CI workflow steps to run preview tests on both Linux and Windows

Reviewed Changes

Copilot reviewed 44 out of 44 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
sycl/cmake/modules/AddSYCLUnitTest.cmake	Adds core functionality to create both regular and preview test variants
sycl/unittests/CMakeLists.txt	Creates new SYCLUnitTestsPreview target and check-sycl-unittests-preview target
Multiple CMakeLists.txt files	Updates all unit test directories to use add_sycl_unittest_both macro
sycl/unittests/scheduler/SchedulerTestUtils.hpp	Updates MockHandler constructor to use new handler_impl interface
sycl/unittests/program_manager/arg_mask/EliminatedArgMask.cpp	Updates MockHandler constructor to use new handler_impl interface
sycl/unittests/scheduler/InOrderQueueSyncCheck.cpp	Updates event creation to use create_default_event()
sycl/unittests/misc/OsUtils.cpp	Disables getCurrentDSODir test for preview builds
sycl/unittests/Extensions/LaunchQueries.cpp	Disables failing tests for preview builds
.github/workflows/sycl-linux-build.yml	Adds preview unit test execution step
.github/workflows/sycl-windows-build.yml	Adds preview unit test execution step

Copilot · 2025-08-04T23:24:52Z

sycl/cmake/modules/AddSYCLUnitTest.cmake

@@ -73,16 +99,29 @@ macro(add_sycl_unittest test_dirname link_variant)
    )
  endif()

-  add_dependencies(check-sycl-unittests check-sycl-${test_dirname})
+  add_dependencies(${check_target_dep} check-sycl-${test_dirname})

  if(WIN32)
    # Windows doesn't support LD_LIBRARY_PATH, so instead we copy the mock OpenCL binary next to the test and ensure
    # that the test itself links to OpenCL (rather than through ur_adapter_opencl.dll)


[nitpick] There's a spelling error in the comment. 'ur_adapter_opencl.dll' should be 'ur_adapter_opencl.dll' (no change needed, comment is actually correct).

sycl/cmake/modules/AddSYCLUnitTest.cmake

sycl/unittests/event/CMakeLists.txt

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

sarnex

cmake lgtm

sarnex · 2025-08-04T23:59:02Z

sycl/cmake/modules/AddSYCLUnitTest.cmake


  if(WIN32)
    # Windows doesn't support LD_LIBRARY_PATH, so instead we copy the mock OpenCL binary next to the test and ensure
    # that the test itself links to OpenCL (rather than through ur_adapter_opencl.dll)
    set(mock_ocl ${CMAKE_CURRENT_BINARY_DIR}/OpenCL.dll)
+
+    # An error is thrown if both the preview and non-preview versions try to


unrelated but do we really need to copy the opencl library to the test dir?

[SYCL][Test] Add CMake target for running SYCL unit tests with ABI br…

b21e042

…eaking changes enabled.

uditagarwal97 had a problem deploying to WindowsCILock August 1, 2025 20:49 — with GitHub Actions Failure

uditagarwal97 self-assigned this Aug 1, 2025

uditagarwal97 added 2 commits August 2, 2025 00:24

Use CMake's copy_if_different to avoid build rule collision

2bf9225

Run unittests in preview mode in CI

e5e5812

uditagarwal97 had a problem deploying to WindowsCILock August 1, 2025 22:28 — with GitHub Actions Failure

uditagarwal97 requested a review from Copilot August 1, 2025 22:52

This comment was marked as outdated.

Sign in to view

Fix windows

7032e8c

uditagarwal97 temporarily deployed to WindowsCILock August 2, 2025 18:22 — with GitHub Actions Inactive

uditagarwal97 temporarily deployed to WindowsCILock August 2, 2025 18:23 — with GitHub Actions Inactive

uditagarwal97 temporarily deployed to WindowsCILock August 2, 2025 18:49 — with GitHub Actions Inactive

uditagarwal97 temporarily deployed to WindowsCILock August 2, 2025 19:02 — with GitHub Actions Inactive

aelovikov-intel reviewed Aug 4, 2025

View reviewed changes

Code reuse between preview and non-preview unittests

63f00e6

uditagarwal97 had a problem deploying to WindowsCILock August 4, 2025 18:23 — with GitHub Actions Error

uditagarwal97 had a problem deploying to WindowsCILock August 4, 2025 18:24 — with GitHub Actions Error

NFC changes, remove incorrect comments, add space at EOF

e3fb020

uditagarwal97 had a problem deploying to WindowsCILock August 4, 2025 18:26 — with GitHub Actions Failure

uditagarwal97 temporarily deployed to WindowsCILock August 4, 2025 18:26 — with GitHub Actions Inactive

Don't call unittest preview from non-preview call

8b63e12

uditagarwal97 temporarily deployed to WindowsCILock August 4, 2025 18:53 — with GitHub Actions Inactive

uditagarwal97 temporarily deployed to WindowsCILock August 4, 2025 19:11 — with GitHub Actions Inactive

Update unittests CMakefile to explicitly specify preview target

f8b3633

uditagarwal97 had a problem deploying to WindowsCILock August 4, 2025 23:11 — with GitHub Actions Error

uditagarwal97 had a problem deploying to WindowsCILock August 4, 2025 23:12 — with GitHub Actions Error

uditagarwal97 requested a review from aelovikov-intel August 4, 2025 23:13

uditagarwal97 changed the title ~~[SYCL][Test] Add CMake target for running SYCL unit tests with ABI beaking changes enabled.~~ [CI][SYCL][Test] Add CMake target for running SYCL unit tests with ABI beaking changes enabled. Aug 4, 2025

uditagarwal97 changed the title ~~[CI][SYCL][Test] Add CMake target for running SYCL unit tests with ABI beaking changes enabled.~~ [CI][SYCL][Test] Add CMake target for running SYCL unit tests with ABI breaking changes enabled Aug 4, 2025

uditagarwal97 requested a review from Copilot August 4, 2025 23:24

Copilot AI reviewed Aug 4, 2025

View reviewed changes

uditagarwal97 commented Aug 4, 2025

View reviewed changes

sycl/unittests/event/CMakeLists.txt Outdated Show resolved Hide resolved

NFC changes

880dfc5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

uditagarwal97 temporarily deployed to WindowsCILock August 4, 2025 23:29 — with GitHub Actions Inactive

uditagarwal97 marked this pull request as ready for review August 4, 2025 23:30

uditagarwal97 requested review from a team as code owners August 4, 2025 23:30

uditagarwal97 requested a review from reble August 4, 2025 23:30

uditagarwal97 temporarily deployed to WindowsCILock August 4, 2025 23:58 — with GitHub Actions Inactive

sarnex approved these changes Aug 4, 2025

View reviewed changes

sarnex requested a review from a team August 4, 2025 23:59

uditagarwal97 temporarily deployed to WindowsCILock August 5, 2025 00:02 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CI][SYCL][Test] Add CMake target for running SYCL unit tests with ABI breaking changes enabled #19687

[CI][SYCL][Test] Add CMake target for running SYCL unit tests with ABI breaking changes enabled #19687

uditagarwal97 commented Aug 1, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

aelovikov-intel Aug 4, 2025 •

edited

Loading

Uh oh!

uditagarwal97 Aug 4, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 4, 2025

Uh oh!

Uh oh!

Uh oh!

sarnex left a comment

Uh oh!

sarnex Aug 4, 2025

Uh oh!

Uh oh!

[CI][SYCL][Test] Add CMake target for running SYCL unit tests with ABI breaking changes enabled #19687

Are you sure you want to change the base?

[CI][SYCL][Test] Add CMake target for running SYCL unit tests with ABI breaking changes enabled #19687

Conversation

uditagarwal97 commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

aelovikov-intel Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

uditagarwal97 Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sarnex left a comment

Choose a reason for hiding this comment

Uh oh!

sarnex Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

uditagarwal97 commented Aug 1, 2025 •

edited

Loading

aelovikov-intel Aug 4, 2025 •

edited

Loading