[Benchmarks] Add option for shallow clones #20137
Conversation
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
force-pushed
the
fetch-head
branch
from
a7e06f4 to
bfa0487
Compare
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| name: str, | ||
| force_rebuild: bool = False, | ||
| no_suffix_src: bool = False, | ||
| shallow_clone: bool = False, |
There was a problem hiding this comment.
why can't this be the default? I think we only need the exact commit/tag?
There was a problem hiding this comment.
I couldn't find a clean way for updating a shallow repo with all kinds of refs (tag, branch, sha). For such repos the way to switch to other commit is to make a clean shallow copy of repo. Most of repositories we use are small enough so we could have some (maybe rare, but still) gains from having a full copy, ie. when debugging an older tag/commit.
On the other hand, having by default a clean shallow copy each time a ref can't be found would ensure that we have a clean state without having to call git --reset or git checkout. It's just that we will have to fetch more data more often.
I'll make a shallow copy a default.
| log.debug(f"Cloning {self._url} into {self.src_dir} at commit {self._ref}") | ||
| git_clone_cmd = "git clone --recursive" | ||
| if self._shallow_clone: | ||
| git_clone_cmd += f" --depth 1 --branch {self._ref}" |
There was a problem hiding this comment.
this won't work for commits.
There was a problem hiding this comment.
Done. Checking if ref is either a branch or a tag, if not, fallback to a full clone.
PatKamin
force-pushed
the
fetch-head
branch
from
bfa0487 to
87a6bf7
Compare
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
To speed up cloning big repositories, add an option for a shallow clone.
To speed up cloning big repositories, add an option for a shallow clone.