[SYCL][Doc] Update proposed device index extension #20640
+58
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our internal customer who is requesting this feature wants the index returned by this API to match the Level Zero device identifier (which is also an index). This is only possible if the index is per-platform instead of globally unique.
steffenlarsen
approved these changes
Nov 14, 2025
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
Overall look good to me! Just one insignificant suggestion.
| static device ext_oneapi_from_index(size_t index); | ||
| class platform { | ||
| // ... | ||
| device ext_oneapi_index_to_device(size_t index) const; |
Contributor
There was a problem hiding this comment.
Nit; I am not fully sold on this name. Maybe ext_oneapi_device_at(size_t index) or ext_oneapi_device_at_index(size_t index)?
Not a strong preference though.
Contributor
Author
There was a problem hiding this comment.
Yes, that seems better. Done in f4d3524.
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our internal customer who is requesting this feature wants the index returned by this API to match the Level Zero device identifier (which is also an index). This is only possible if the index is per-platform instead of globally unique.