[SYCL] Drain thread pool should not be called on Win#7973
Conversation
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
|
/verify with intel/llvm-test-suite#1462 |
|
/verify with intel/llvm-test-suite#1462 |
|
I ran this PR against the llvm-test-suite on Windows. I see some failures, but none of the timeouts that this PR fixes. I think we should merge. Oh, and the llvm-test-suite run just completed. There is a failure in Basic/event_profiling_info.cpp, but still that's far better than the timeouts which are dragging the whole CI system down. We should merge. |
|
failing Basic/event_profiling_info is not related to drain & deferred buffers functionality since it is failing with the following error: |
I'm not sure if current test behavior is friendly for developers. @intel/llvm-reviewers-runtime, do we want the test to fail, or skip is HW doesn't support profiling? Maybe running on OpenCL device with version >= 2.1 must be a prerequisite for launching pre-commit tests? |
|
It looks like this PR caused the following failure in post commit: https://github.com/intel/llvm/actions/runs/3886587010/jobs/6631863893 @KseniyaTikhomirova will you be able to take a look? |
|
@KseniyaTikhomirova - In reference to the last comment from Artur, about the failing unit test. In my observations, that test seems to pass on Linux, but sometimes fail on Win. |
My modifications broke attachScheduler() instrumentation for tests. SHould be fixed here #8006 |
Signed-off-by: Tikhomirova, Kseniya kseniya.tikhomirova@intel.com
PR #7908 accidentally introduced a behavior that causes lots of timeouts on the CI system on Windows.