Remove unused examples #2230
Merged
Remove unused examples #2230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>
Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>
There was a problem hiding this comment.
Pull Request Overview
This PR removes a large set of outdated and unused example scripts, notebooks, and configuration entries across NLP and image recognition quantization examples.
- Deleted static/dynamic PTQ example scripts under
onnxrt/nlp/huggingface_modelandonnxrt/image_recognition/unet - Removed the PyTorch quick-start notebook, benchmark scripts, and related requirements
- Cleaned up example parameter configuration files and top‐level documentation
Reviewed Changes
Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/onnxrt/nlp/huggingface_model/text_classification/quantization/ptq_static/run_quant.sh (and siblings) | Removed unused static PTQ shell scripts |
| examples/onnxrt/nlp/huggingface_model/text_classification/quantization/ptq_dynamic/run_quant.sh (and siblings) | Removed unused dynamic PTQ shell scripts |
| examples/onnxrt/nlp/huggingface_model/code_detection/quantization | Deleted CodeBERT quantization examples |
| examples/onnxrt/image_recognition/unet/quantization/ptq_static/* | Deleted Unet quantization example scripts |
| examples/notebook/pytorch/* | Removed PyTorch notebook, benchmark, and requirements |
| examples/.config/model_params_onnxrt.json | Cleaned out parameters for removed examples |
| examples/.config/model_params_onnxrt_win.json | Cleaned out Win config entries |
| examples/README.md | Stripped links to deprecated examples |
| .pre-commit-config.yaml | Updated exclude patterns to drop removed example paths |
Comments suppressed due to low confidence (4)
examples/.config/model_params_onnxrt_win.json:29
- Make sure the remaining JSON after removing obsolete model entries is still valid and no commas or braces are misplaced.
"input_model": "models/onnx/DUC/ResNet101-DUC-12.onnx",
.pre-commit-config.yaml:110
- [nitpick] Confirm that the pre-commit exclude patterns still correctly skip only intended files now that many example paths have been removed.
examples/.+|
examples/.config/model_params_onnxrt.json:485
- After bulk deletions of JSON entries, ensure that there are no trailing commas or structural issues that would break JSON parsing.
},
chensuyue
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
feature or bug fix or documentation or validation or others
API changed or not
Description
detail description
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed