Skip to content

Api key leakage #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vartikad wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Api key leakage #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3454a55
Added TLS check to avoid API Key leakage
vartikad Oct 19, 2023
6aef09d
Updated error message
vartikad Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ func SetupConfig(envFilePath string) error {
return errors.New("Trust Authority base URL needs to be provided in configuration")
}

if !strings.HasPrefix(configValues.TrustAuthorityBaseUrl, "https://") {
Copy link
Contributor

@arijit8972 arijit8972 Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is someone changes the config file post installation, will this check still work ?

Copy link
Contributor Author

@vartikad vartikad Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will raise another PR against internal branch.

return errors.New("Invalid Trust Authority base URL, must start with 'https://'")
}

_, err = url.Parse(configValues.TrustAuthorityBaseUrl)
if err != nil {
return errors.Wrap(err, "Invalid Trust Authority Base URL")
Expand Down