Fix risk area handling to prevent unwanted rate errors and ensure valid methods are still displayed#48
Open
robsoned wants to merge 1 commit intointelipost:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the logic responsible for handling delivery methods that contain a delivery_note related to risk areas.
Previously, the module appended an error to the shipping rate result (via append($error) or setError(true)), which prevents Magento from displaying any valid shipping methods, even when they exist. This happened regardless of whether delivery_risk_areas was enabled or disabled, resulting in checkout being blocked unnecessarily.
The new implementation ensures that:
Checklist:
Testing Instructions: