Bring push plugin up to date #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ios VoIP Push feature * VoIP feature bugs fixed * VoIP JS connector * VoIPPush feature included in the main PushPlugin class * VoIP feature: Removed sources from config.xml * VoIP feature: PushKit framework fixed in plugin.xml * Update API.md * Update PAYLOAD.md * API.md suggestions modified * PushPlugin.m pull request requested changes * push.js reverted to previous commit * PushPlugin.m removed unused code
⬆️ Bump dependency for cordova-android to 7.1.0 which forces the use of version 3.0.1 gradle tools.
…ted our channel if no channels were created, there could be other channels created already so this would leave us without our channel. We should explicitly check if our channel exists, and not assume we are the only channel. (#2249)
…/inputmethod/InputConnectionCompat
…ed with phonegap-plugin-push v2.2.0
…o PAYLOAD.md (#2306) * Added description of sample JSON message format to PAYLOAD.md * minor fix in link * added "sound" to sample JSON message, fixed whitespace in indent * fixed again broken link in PAYLOAD.md * added new section on Message Format Overview to TOC, fixed some typos, fixed content_available -> content-available, added sub headings
Fix mis-spelling.
* Fixes android channel vibration setting Allow users to change default Android channel settings on init * Update API doc with Android channel properties
* AWS Pinpoint Enhancement * AWS Pinpoin Enhancement - picture message
…e for FCM_VERSION (#2425)
…droid Only) (#2192) * Added a clearNotification method to clear a single notification (Android only) * Added changes to docs, updated formatting, added tests * Updated API.md, Moved id arg, added more error checking
* Update PAYLOAD.md All the payload details from the README refer to using the deprecated GCM service. Here I've added a small example to send push notifications to the FCM legacy HTTP server protocol, including the basic fields such as title, body, icon, color, sound, and optional payload data. * Update PAYLOAD.md
… iOS and update documentation (#2478)
…nge sound file???
Member
|
@jpike88 thank you for submitting this PR. We have tested this locally with the sample app and ran into a few issues after resolving the merge conflicts. We see version conflicts with Resolving that we also see a conflict The final conflict after that is around conflicting versions of To merge this PR could you rebase and resolve those conflicts. Alternatively we can resolve these and open our own PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the breaking builds on cordova@8.1.2, cordova-ios@4.5.5, cordova-android@7.1.1. I've switched to using the main repo instead of this one, and confirmed that it builds smoothly.
Also, this really shouldn't have been a fork. It's 59 commits behind the main repo, and your existing PR (#20) seems to be diverging further in a direction that's unnecessary, and appears to be solved via some extra gradle code and an improvement to the main repo that broadcasts that message data so your main intercom activity can intercept it. This is going to be a continual compatibility pain for all intercom customers who rely on cordova apps.
Please update this ASAP.
Would also appreciate you guys opened your issues up so I don't have to keep bouncing through your customer support system.
Related issues:
phonegap#1640
phonegap#2582