Fix issue15 private registry support#16
Fix issue15 private registry support#16antoinetran wants to merge 6 commits intointerlink-hq:mainfrom
Conversation
9b12542 to
4a226d9
Compare
…fields + added pullSecrets and pullPolicy => break image override compatibility test-connection with namespace Signed-off-by: antoinetran <antoinetran@users.noreply.github.com>
4a226d9 to
b28ebc9
Compare
dciangot
left a comment
There was a problem hiding this comment.
@antoinetran LGTM. I need to check where the impact is in the documentation and installer script. I cannot release it without having the changes ready also there.
…age + improv template Signed-off-by: antoinetran <antoinetran@users.noreply.github.com>
…Policy Signed-off-by: antoinetran <antoinetran@users.noreply.github.com>
Signed-off-by: antoinetran <antoinetran@users.noreply.github.com>
Signed-off-by: antoinetran <antoinetran@users.noreply.github.com>
|
Also includes a fix in values.yaml and regression fix of |
Signed-off-by: antoinetran <antoinetran@users.noreply.github.com>
|
Includes an improvement over the slurm config yaml in the values.yaml: it can either be a string (as before to not break compatibility), but also a dict. The purpose is to be able to override this config particular values.yaml with others. Without this, there would be duplication of the whole slurm config yaml. Example with the improvement: values-somehpc1.yaml would result in a merge of both plugin config. The drawback is that the comments or ordering are lost in the rendered file but this is not really important usually. |
Summary
All described in the related issue description.
Tested working in HPC where private registry is mandatory, and direct docker pull is not possible.
Related issue :
#15