fix: added parameter SkipDownwardAPIResolution to InterLinkConfig and…#44
fix: added parameter SkipDownwardAPIResolution to InterLinkConfig and…#44mginfn wants to merge 1 commit intointerlink-hq:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds the missing SkipDownwardAPIResolution configuration parameter to the InterLink Helm chart configuration files. The parameter controls whether the Downward API resolution should be skipped in the virtual kubelet, and is being added alongside the existing ExportPodData parameter.
Changes:
- Added
skipDownwardAPIResolution: falsedefault value tovalues.yaml - Added
SkipDownwardAPIResolutionparameter mapping in the virtual-kubelet-config template
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| interlink/values.yaml | Adds skipDownwardAPIResolution: false default value to the interlink configuration section |
| interlink/templates/virtual-kubelet-config.yaml | Maps the new parameter from values to the InterLinkConfig.yaml in the virtual-kubelet-config ConfigMap |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| CACertFile: {{ .Values.interlink.tls.caCertFile | quote }} | ||
| {{- end }} | ||
| {{- end }} | ||
| ExportPodData: {{ .Values.interlink.exportPodData }} |
There was a problem hiding this comment.
The SkipDownwardAPIResolution parameter should also be added to this InterLinkConfig.yaml section for consistency. This section generates the interlink-config ConfigMap (when interlink.enabled is true), similar to how ExportPodData is present in both the virtual-kubelet-config ConfigMap (line 32) and the interlink-config ConfigMap (line 127). The parameter should be added after ExportPodData with the same pattern.
Add missing parameter
SkipDownwardAPIResolutiontoInterLinkConfig.yamlandvalues.yaml.