Skip to content

fix: added parameter SkipDownwardAPIResolution to InterLinkConfig and…#44

Open
mginfn wants to merge 1 commit intointerlink-hq:mainfrom
mginfn:fix/missing-skipDownwardAPIResolution
Open

fix: added parameter SkipDownwardAPIResolution to InterLinkConfig and…#44
mginfn wants to merge 1 commit intointerlink-hq:mainfrom
mginfn:fix/missing-skipDownwardAPIResolution

Conversation

@mginfn
Copy link
Collaborator

@mginfn mginfn commented Feb 20, 2026

Add missing parameter SkipDownwardAPIResolution to InterLinkConfig.yaml and values.yaml.

Copilot AI review requested due to automatic review settings February 20, 2026 12:25
@mginfn mginfn requested a review from dciangot as a code owner February 20, 2026 12:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds the missing SkipDownwardAPIResolution configuration parameter to the InterLink Helm chart configuration files. The parameter controls whether the Downward API resolution should be skipped in the virtual kubelet, and is being added alongside the existing ExportPodData parameter.

Changes:

  • Added skipDownwardAPIResolution: false default value to values.yaml
  • Added SkipDownwardAPIResolution parameter mapping in the virtual-kubelet-config template

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
interlink/values.yaml Adds skipDownwardAPIResolution: false default value to the interlink configuration section
interlink/templates/virtual-kubelet-config.yaml Maps the new parameter from values to the InterLinkConfig.yaml in the virtual-kubelet-config ConfigMap

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CACertFile: {{ .Values.interlink.tls.caCertFile | quote }}
{{- end }}
{{- end }}
ExportPodData: {{ .Values.interlink.exportPodData }}
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SkipDownwardAPIResolution parameter should also be added to this InterLinkConfig.yaml section for consistency. This section generates the interlink-config ConfigMap (when interlink.enabled is true), similar to how ExportPodData is present in both the virtual-kubelet-config ConfigMap (line 32) and the interlink-config ConfigMap (line 127). The parameter should be added after ExportPodData with the same pattern.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants