Conversation
…iter into video-metadata
README.md
Outdated
| to index all WARC records in the file | ||
| --screenshot-mode Special Wayback Machine mode for handling WARCs | ||
| containing screenshots | ||
| --video-mode Special Wayback Machine mode for handling WARCs containing video |
There was a problem hiding this comment.
I believe --video-mode option is now gone. this line should be removed?
There was a problem hiding this comment.
Thought I did - agreed it should be removed.
cdx_writer/dispatcher.py
Outdated
| def dispatch_warcinfo(self, record, env): | ||
| return WarcinfoHandler | ||
|
|
||
| def dispatch_metadata(self, record, env): |
There was a problem hiding this comment.
do we need to repeat this in this class? AllDispatcher is extending DefaultDispatcher.
cdx_writer/dispatcher.py
Outdated
| def dispatch_metadata(self, record, env): | ||
| content_type = record.content_type | ||
|
|
||
| if content_type and content_type.startswith('application/json;generator-youtube-dl'): |
There was a problem hiding this comment.
mimetype is application/json;generator=youtube-dl?
There was a problem hiding this comment.
I am open to making anything you want. I thought it captured what we needed. Suppose we save some other type of metadata from something not youtube-dl. We could then change the identifier to "generator-different-app" making it easily identifiable for parsing. But that is my assumption with knowing all the details of the playback code.
2 participants
Removed video metadata as option. Will now process automatically.