let's see what's new in this fork of the warc lib #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And it is failing now.
… filename is not specified.
Manual addition of some bugfixes found in upstream issues and pull requests.
Almost certainly broken.
Numerous small changes. Update for python3, attempt to remove gzip2 and use standard library instead. Began creating small tool for HTTP parsing. Probobly utterly broken.
Added warcscrape.py and supporting files.
gzip.open() expects a string as filename. In the prior implementation it passed a fileobject as argument. This resulted in a type error. Changing it to pass the name of the file as argument to gzip.open() fixes this problem.
The old approach assumed to much about the internals of requests and ended up with an empty body, it also mixed byte encoded content with regular python strings (the latter was the intention so I adapted the code to that).
…aw bytes instead. This simplifies the code and fixes an alignment bug. It also moves the decoding responsibility the the user to the user of the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.