feat-1338: Validate domain names before creating auctions#1435
Open
OlegPhenomenon wants to merge 2 commits intomasterfrom
Open
feat-1338: Validate domain names before creating auctions#1435OlegPhenomenon wants to merge 2 commits intomasterfrom
OlegPhenomenon wants to merge 2 commits intomasterfrom
Conversation
Add domain name validation to Registry::AuctionCreator to prevent auctions for invalid domain names according to .ee regulations: - Domain names can only contain letters (including Estonian), numbers, and dashes - Names cannot start or end with a dash - Names cannot have dashes at both 3rd and 4th positions - Names must be 1-63 characters long - Underscores and special characters are not allowed Invalid domains are logged and skipped during auction creation. Test domains (.test extension) bypass validation for compatibility with existing test fixtures. Added comprehensive tests for domain validation covering both valid and invalid domain patterns.
OlegPhenomenon
force-pushed
the
1338-validate_domain_name-before_auction
branch
from
7fceecf to
b219dc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1338
Add domain name validation to Registry::AuctionCreator to prevent
auctions for invalid domain names according to .ee regulations:
Invalid domains are logged and skipped during auction creation.
Test domains (.test extension) bypass validation for compatibility
with existing test fixtures.
Added comprehensive tests for domain validation covering both valid
and invalid domain patterns.