Skip to content

Migrate codeclimate to qlty#9

Open
mmeest wants to merge 7 commits intomasterfrom
migrate-codeclimate-to-qlty
Open

Migrate codeclimate to qlty#9
mmeest wants to merge 7 commits intomasterfrom
migrate-codeclimate-to-qlty

Conversation

@mmeest
Copy link
Copy Markdown
Contributor

@mmeest mmeest commented Aug 13, 2025

This update will migrate .codeclimate to qlty.toml

@mmeest mmeest requested a review from maricavor August 22, 2025 08:47
@mmeest
Copy link
Copy Markdown
Contributor Author

mmeest commented Sep 11, 2025

Test Fix

Fixed failing test test_parses_response_with_payload that was causing CI to fail.

Problem

  • Test was making real HTTP requests instead of using mocked responses
  • WebMock was blocking the request because the stub didn't match exactly
  • This caused the test to fail with WebMock::NetConnectNotAllowedError

Solution

  • Updated WebMock stub to use regex matching for the request body
  • Simplified header matching to only check essential headers
  • Made the test more maintainable and less fragile

Changes

  • Modified test_parses_response_with_payload in test/client_test.rb
  • Changed from exact XML body matching to regex pattern /esindus_v1/
  • Simplified header validation to only check Soapaction

This ensures the test focuses on functionality rather than implementation details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant