Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did I do?
internetee/ruby:3.2.2-refactor.Why did I do it?
RUBY_VERwas added so that it would be easy to handle Ruby versions when there's an update. It's also considered good practice to store versions in a separate variable, making that variable a single source of truth.How to test?
For the Dockerfile responsible for deployment in a test environment, you need to change the base image to: internetee/ruby:3.2.2-refactor, and rebuild it. Since only our auction runs in Docker Swarm, I think this change mainly concerns the auction. I created a specific PR internetee/auction_center#1103, in which the updated Dockerfiles are located. If in the test environment the images don't crash, then I believe it's ready to merge. The changes in the Dockerfile related to the auction can be read in the PR description.