Added custom amounts for generating oneoff links#114
Open
Added custom amounts for generating oneoff links#114
Conversation
OlegPhenomenon
approved these changes
Jun 26, 2024
app/models/invoice.rb
Outdated
| def payment_reference_must_change | ||
| if payment_reference.present? && payment_reference == payment_reference_was | ||
| errors.add(:payment_reference, 'must be different from the existing payment reference') | ||
| end |
Contributor
There was a problem hiding this comment.
I think better will be
def payment_reference_must_change
return unless payment_reference.present? && payment_reference == payment_reference_was
errors.add(:payment_reference, 'must be different from the existing payment reference')
end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close internetee/auction_center#1216