-
Notifications
You must be signed in to change notification settings - Fork 3
[PB-4201]: feat/health check server setup #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
larryrider
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, shouldn't be better to create this "server" in another git project?
It has its own package.json, .env, .gitignore, config, methods, etc.
It is not included in the build so its not really related to this project.
What are the advantages of having it inside this project instead of outside by its own?
If we put it in a separate project, we risk the monitoring tests getting out of date and creating extra work to manage dependencies between two different repositories. Keeping them together ensures the test always matches the code. |
|
@sg-gs This is just a kickoff, looks good to me. WDYT? |
|
The idea is to keep the SDK in sync with the EPs health checks that we use as monitors @larryrider, so each time you add an EP, a monitor is automatically created / updated |
sg-gs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions:
- How are we adding an EP for each SDK method? This should be as automatic as possible and it is, in fact, the important point here. I see some imports of '/drive/routes' but that should not be the case nor the idea of this initiative is. Only complex cases could be added manually by overriding
- Why Fastify? Only one project is using this technology right now. Nest.js has been our way-to-go these last 3 years.
hey @sg-gs:
|
Yeah, in theory it is. Let's see first if you can make it work without it (as automatic as possible, I assume Swagger could help here), but still, Fastify was a test but this health-check thing is not for scaling it, it will receive like 100 requests/minute. I would go the Express route, as it is the other option we use. WDYT @apsantiso ? |
Adds a Fastify-based health check server in health-check-server/ to monitor Internxt API endpoints for Uptime Robot.