[PB-5294]: feat/create-suite-launcher-component #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
larryrider
commented
Dec 1, 2025
larryrider
commented
- Creates SuiteLauncher component with its tests
- Improves dialog component by allowing support to JSX elements and adding optional maxWidth prop
- Improves popover component
…d adding maxWidth prop
xabg2
reviewed
Dec 1, 2025
Comment on lines
+66
to
+73
| ) : isValidElement(suiteApp.icon as JSX.Element) ? ( | ||
| cloneElement(suiteApp.icon as JSX.Element, { | ||
| size: 26, | ||
| className: | ||
| `${suiteApp.icon.props?.className ?? ''} ${suiteApp.isMain ? 'text-primary' : ''} ` + | ||
| `${suiteApp.availableSoon || suiteApp.isLocked ? 'opacity-50 filter grayscale' : ''}`, | ||
| weight: suiteApp.isMain ? 'fill' : 'regular', | ||
| }) |
xabg2
reviewed
Dec 1, 2025
| className="font-medium dark:font-normal text-purple-10 dark:text-purple-1" | ||
| style={{ lineHeight: 1, fontSize: 'xx-small' }} | ||
| > | ||
| {soonText ?? 'Soon'} |
Collaborator
There was a problem hiding this comment.
Maybe we can pass the label as a prop😄
Contributor
Author
There was a problem hiding this comment.
It could be a good option, but for now I think its better this way so its easier to config (you only decide if its availableSoon, if its disabled or if its main, and ui just decides its css.
If its needed in the future, we can always add more complexity to it
xabg2
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.