[security] Require client certificate to connect to yugabyte sql interface #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barroco
changed the title
mickmis
approved these changes
Dec 2, 2025
| { | ||
| all(metadata): if metadata.datastore == 'yugabyte' then { | ||
| // Replicated from the official Helm chart with all command-line flags | ||
| MasterGFlags: base.Secret(metadata, 'dss-dss-yugabyte-master-gflags') { |
Contributor
There was a problem hiding this comment.
use_client_to_server_encryption is not present in the master gflags (it is for the tserver though), while it is set for the helm charts.
Contributor
There was a problem hiding this comment.
Yes, it don't need to be set for helm charts ^^'
the-glu
approved these changes
Dec 3, 2025
Contributor
the-glu
left a comment
the-glu
left a comment
There was a problem hiding this comment.
Tested and confirmed working, however extrra flag can be removed :)
|
|
||
| gflags: | ||
| master: | ||
| use_client_to_server_encryption: true |
Contributor
There was a problem hiding this comment.
It's not needed to set this flag explicitly, it's handled in the state file via line 52 above (19d9d1ce3665e9d62d9a2538267116eb6a90644b9275b38ab30aeac127076243R52)
| { | ||
| all(metadata): if metadata.datastore == 'yugabyte' then { | ||
| // Replicated from the official Helm chart with all command-line flags | ||
| MasterGFlags: base.Secret(metadata, 'dss-dss-yugabyte-master-gflags') { |
Contributor
There was a problem hiding this comment.
Yes, it don't need to be set for helm charts ^^'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces ssl and authentication of clients on ysql connections using client certificate.