fix: handling of long strings in slack plugin#2464
Merged
hipstersmoothie merged 1 commit intointuit:mainfrom Jun 28, 2024
Merged
fix: handling of long strings in slack plugin#2464hipstersmoothie merged 1 commit intointuit:mainfrom
hipstersmoothie merged 1 commit intointuit:mainfrom
Conversation
LittleGreenYoda42
changed the title
Contributor
Author
|
@hipstersmoothie could you have a look? |
hipstersmoothie
approved these changes
Jun 28, 2024
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Fixing the code to split long lines into shorter chunks in the slack plugin.
Why
The code was broken and the failing tests made the CI pipeline fail as well.
This change solves the failing tests in https://github.com/intuit/auto/actions/runs/9039953720/job/24843604205#step:6:296 which should unblock the PR #2459
Todo:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor