Update gcode.c #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a t_encountered flag to gc_execute_line. This allows for a check before updating gc_state.tool as without this check, gc_state.tool was always updated with all modal changes regardless of if the user passed a T command or not. Previous behavior: $G> [GC:G0 G54 G17 G21 G90 G94 M5 M9 T0 F0 S0] T4> [GC:G0 G54 G17 G21 G90 G94 M5 M9 T4 F0 S0] G91> [GC:G0 G54 G17 G21 G91 G94 M5 M9 T0 F0 S0] New behavior: $G> [GC:G0 G54 G17 G21 G90 G94 M5 M9 T0 F0 S0] T4> [GC:G0 G54 G17 G21 G90 G94 M5 M9 T4 F0 S0] G91> [GC:G0 G54 G17 G21 G91 G94 M5 M9 T4 F0 S0]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a t_encountered flag to gc_execute_line.
This allows for a check before updating gc_state.tool as without this check, gc_state.tool was always updated with all modal changes regardless of if the user passed a T command or not. Previous behavior:
$G> [GC:G0 G54 G17 G21 G90 G94 M5 M9 T0 F0 S0]
T4> [GC:G0 G54 G17 G21 G90 G94 M5 M9 T4 F0 S0]
G91> [GC:G0 G54 G17 G21 G91 G94 M5 M9 T0 F0 S0]
New behavior:
$G> [GC:G0 G54 G17 G21 G90 G94 M5 M9 T0 F0 S0]
T4> [GC:G0 G54 G17 G21 G90 G94 M5 M9 T4 F0 S0]
G91> [GC:G0 G54 G17 G21 G91 G94 M5 M9 T4 F0 S0]