This repository was archived by the owner on Feb 4, 2021. It is now read-only.
Upgrade to use separate proptypes library for react 16#172
Open
suark wants to merge 2 commits intoinvertase:masterfrom
suark:proptype_upgrade
Open
Upgrade to use separate proptypes library for react 16#172suark wants to merge 2 commits intoinvertase:masterfrom suark:proptype_upgrade
suark wants to merge 2 commits intoinvertase:masterfrom
suark:proptype_upgrade
Conversation
|
Please merge this PR |
|
+1 to please merge this PR |
|
|
Author
|
hopefully this is still possible. I deleted my fork haha. It was made almost 2 years ago |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In react 16 and up, React.Proptypes no longer exists. Instead we must use the new, separate proptypes library:
https://github.com/facebook/prop-types
react-native version 0.49 uses react 16 https://github.com/facebook/react-native/blob/v0.49.0/package.json#L135
So react-native-material-design must be updated or it will be remain incompatible with newer versions of react-native.
I have removed any references to the React.proptypes while also updating the dependency of react-native-vector-icons
That dependency has been updated to use the correct proptypes so we only have to update to the newest and it is fine.
I ran the linting and noticed that the master branch contains roughly 220 linting errors and after my changes, it still has the exact same number. So my PR should not be rejected due to linting errors that I did not cause.
Should resolve #170