Skip to content

Upgrade numpy and carla to latest version#258

Open
Ruishenl wants to merge 3 commits intodevelopfrom
upgrade-numpy-and-carla-dependency
Open

Upgrade numpy and carla to latest version#258
Ruishenl wants to merge 3 commits intodevelopfrom
upgrade-numpy-and-carla-dependency

Conversation

@Ruishenl
Copy link
Contributor

We can do a dev release first to test the new package to see if it install correctly @KieranRatcliffeInvertedAI

@KieranRatcliffeInvertedAI
Copy link
Contributor

For visibility, we will need to figure out the required numpy version for the Carla python API before I can approve this PR. Last I checked they need before 2.x so we'll need to double check and speak with their dev team if that's still the case.

@Ruishenl
Copy link
Contributor Author

For visibility, we will need to figure out the required numpy version for the Carla python API before I can approve this PR. Last I checked they need before 2.x so we'll need to double check and speak with their dev team if that's still the case.

The fact that i am able to auto resolve both numpy 2.x and carla 0.9.15 is a promising sign

Copy link
Contributor

@KieranRatcliffeInvertedAI KieranRatcliffeInvertedAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to select "Request changes" at this time though the effort is on Carla's side on whether they're going to increment their version of Numpy.

tqdm = "^4.65.0"
numpy = "^1.24.4"

numpy = "^2.2.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carla has yet to increment their version of numpy therefore I cannot justify this PR at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants