Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/zcl_aw_part_value.clas.abap
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ CLASS zcl_aw_part_value IMPLEMENTATION.
METHOD zif_aw_part_value~value_return_dynamic.

IF i_return_address = abap_true.
e_result = VALUE zif_aw_types=>address( ).
e_result = VALUE zif_aw_types=>address( ).
ELSEIF i_return_person = abap_true.
e_result = VALUE zif_aw_types=>person( ).
ELSE.
Expand All @@ -44,7 +44,8 @@ CLASS zcl_aw_part_value IMPLEMENTATION.
ENDMETHOD.

METHOD zif_aw_part_value~value_fill_table_for_next.
result = VALUE #( FOR i = 0 WHILE i <= 4 ( substring( off = i val = sy-abcde len = 1 ) ) ).
result = VALUE #( FOR i = 0 WHILE i <= 4 ( substring( off = i
val = sy-abcde len = 1 ) ) ).
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line break multiple parameters

Suggest following fix,

Suggested change
val = sy-abcde len = 1 ) ) ).
val = sy-abcde
len = 1 ) ) ).

ENDMETHOD.

ENDCLASS.
14 changes: 1 addition & 13 deletions src/zcl_aw_part_value.clas.testclasses.abap
Original file line number Diff line number Diff line change
@@ -1,19 +1,7 @@
CLASS test DEFINITION FINAL
INHERITING FROM zcl_aw_tm_part_Value
INHERITING FROM zcl_aw_tm_part_value
FOR TESTING
DURATION SHORT
RISK LEVEL HARMLESS.

PRIVATE SECTION.
METHODS setup.
DATA cut TYPE REF TO zcl_aw_part_value.
ENDCLASS.


CLASS test IMPLEMENTATION.

METHOD setup.
cut = NEW #( ).
ENDMETHOD.

ENDCLASS.
33 changes: 33 additions & 0 deletions src/zcl_aw_test_helper.clas.abap
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@

CLASS zcl_aw_test_helper DEFINITION
PUBLIC
CREATE PUBLIC .

PUBLIC SECTION.

DATA mo_class_to_test_generic TYPE REF TO object .

METHODS constructor .
PROTECTED SECTION.
PRIVATE SECTION.
ENDCLASS.



CLASS ZCL_AW_TEST_HELPER IMPLEMENTATION.


METHOD constructor.
TRY.
DATA(lv_classname) = cl_abap_classdescr=>get_class_name( me ).
FIND REGEX '\\PROGRAM=([^=]+)' IN lv_classname SUBMATCHES lv_classname ##REGEX_POSIX.
lv_classname = lv_classname(30).
CREATE OBJECT me->mo_class_to_test_generic TYPE (lv_classname).
CATCH cx_root ##NO_HANDLER ##CATCH_ALL.
ENDTRY.

IF me->mo_class_to_test_generic IS NOT BOUND.
MESSAGE a000(oo) WITH 'unable to create class to test' lv_classname ##NO_TEXT.
ENDIF.
ENDMETHOD.
ENDCLASS.
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,13 @@
<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
<asx:values>
<VSEOCLASS>
<CLSNAME>ZCL_AW_TEST_MASTER</CLSNAME>
<CLSNAME>ZCL_AW_TEST_HELPER</CLSNAME>
<LANGU>E</LANGU>
<DESCRIPT>ABAP Workshop: Test master</DESCRIPT>
<CATEGORY>05</CATEGORY>
<DESCRIPT>ABAP Workshop: Test helper</DESCRIPT>
<STATE>1</STATE>
<CLSCCINCL>X</CLSCCINCL>
<FIXPT>X</FIXPT>
<UNICODE>X</UNICODE>
<DURATION_TYPE>12</DURATION_TYPE>
<RISK_LEVEL>11</RISK_LEVEL>
</VSEOCLASS>
</asx:values>
</asx:abap>
Expand Down
17 changes: 0 additions & 17 deletions src/zcl_aw_test_master.clas.abap

This file was deleted.

55 changes: 34 additions & 21 deletions src/zcl_aw_tm_part_value.clas.abap
Original file line number Diff line number Diff line change
@@ -1,25 +1,35 @@
CLASS zcl_aw_tm_part_value DEFINITION
INHERITING FROM zcl_aw_test_master
FOR TESTING
RISK LEVEL HARMLESS
DURATION SHORT
PUBLIC
CREATE PUBLIC .

PUBLIC SECTION.
PROTECTED SECTION.
METHODS structure FOR TESTING.
METHODS table FOR TESTING.
METHODS dynamic FOR TESTING.
methods table_letters for testing.
PRIVATE SECTION.
DATA cut TYPE REF TO zif_aw_part_value.
METHODS setup.
class ZCL_AW_TM_PART_VALUE definition
public
inheriting from ZCL_AW_TEST_HELPER
abstract
create public
for testing
duration short
risk level harmless .

public section.

methods CONSTRUCTOR .
protected section.

methods STRUCTURE
for testing .
methods TABLE
for testing .
methods DYNAMIC
for testing .
methods TABLE_LETTERS
for testing .
private section.

data CUT type ref to ZIF_AW_PART_VALUE .
ENDCLASS.



CLASS zcl_aw_tm_part_value IMPLEMENTATION.
CLASS ZCL_AW_TM_PART_VALUE IMPLEMENTATION.


METHOD structure.
cl_abap_unit_assert=>assert_equals(
exp = VALUE zif_aw_types=>address(
Expand All @@ -36,9 +46,6 @@ CLASS zcl_aw_tm_part_value IMPLEMENTATION.
i_country = 'US' ) ).
ENDMETHOD.

METHOD setup.
cut = NEW zcl_aw_part_value( ).
ENDMETHOD.

METHOD table.

Expand All @@ -48,6 +55,7 @@ CLASS zcl_aw_tm_part_value IMPLEMENTATION.
ELSE abap_false ) ).
ENDMETHOD.


METHOD dynamic.

"check address type
Expand Down Expand Up @@ -78,4 +86,9 @@ CLASS zcl_aw_tm_part_value IMPLEMENTATION.

ENDMETHOD.


METHOD constructor.
super->constructor( ).
cut ?= mo_class_to_test_generic.
ENDMETHOD.
ENDCLASS.
7 changes: 7 additions & 0 deletions src/zcl_aw_tm_part_value.clas.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@
<DURATION_TYPE>12</DURATION_TYPE>
<RISK_LEVEL>11</RISK_LEVEL>
</VSEOCLASS>
<DESCRIPTIONS>
<SEOCOMPOTX>
<CMPNAME>CONSTRUCTOR</CMPNAME>
<LANGU>E</LANGU>
<DESCRIPT>CONSTRUCTOR</DESCRIPT>
</SEOCOMPOTX>
</DESCRIPTIONS>
</asx:values>
</asx:abap>
</abapGit>