This repository was archived by the owner on May 19, 2021. It is now read-only.
Open
Conversation
@todo: remove template-dependency in py-code
Member
There was a problem hiding this comment.
should be with redis .text_rendered – just as reminder ;)
It only caused database troubles in the past, so i do not think, that it is needed to offer this function in the default layout.
You only mark the messages there. If you click on the checkbox,it nothing will be deleted. So this label is wrong.
It doesn't make any sense to define a footer, if you use the max collspan.
Since it is planed to delete the messages in the feature after some time, it will a uncommon usecase to display messages from deleted users. Also the amount of checks is quite ugly inside the template.
Lyra2108
force-pushed
the
private-message
branch
from
b070644 to
f48bd8d
Compare
Member
Contributor
|
test this please |
* Remove unneeded get_text() * Add missing space * Remove duplicated csrf-token
* Use nesting * Remove unneeded and broken handling for smaller devices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is about closing issue #90 and adding the private message function to the default theme