feat: add support for monorepos and JS-Controller 5#371
Open
AlCalzone wants to merge 6 commits intoioBroker:mainfrom
Open
feat: add support for monorepos and JS-Controller 5#371AlCalzone wants to merge 6 commits intoioBroker:mainfrom
AlCalzone wants to merge 6 commits intoioBroker:mainfrom
Conversation
Contributor
Author
|
This has been tested extensively and seems to be working, with the caveat that the dev has to manually execute |
foxriver76
reviewed
Apr 3, 2023
| useSymlinks: boolean, | ||
| ): Promise<void> { | ||
| await this.buildLocalAdapter(); | ||
| // await this.buildLocalAdapter(); |
Collaborator
There was a problem hiding this comment.
nit: personally I am not a fan of out commented code, as we have git history to know how it looked like a while ago
Contributor
Author
There was a problem hiding this comment.
I may have forgotten to clean this up 😇
foxriver76
approved these changes
Apr 3, 2023
Collaborator
|
@dependabot rebase |
Contributor
Author
|
@Apollon77 I'm not Dependabot 🫣 |
Collaborator
|
lol :-) sorry |
Collaborator
|
@foxriver76 @AlCalzone Should we merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR and ioBroker/ioBroker.js-controller#2103, dev-server can now be used in the JS-Controller 5 monorepo. The install command must be changed slightly, because dev-server needs to know where the "entrypoint" is, and we should be using symlinks to avoid having to pack and install 8 packages on each change:
For executing the controller, it is recommended NOT to build and not to install (symlinks make the later unnecessary). Not sure if we should automatically do this:
TODO:
dev-server rundev-server debugdev-server watch