Open
Conversation
This required even more refactoring
It was only used once
With port-forwarding, this is the easiest way to know if the port was successfully forwarded
Source maps don't work yet.
Fixes #503
"Attach to Node Process (legacy)" doesn't exist anymore, we need to attach to the port
Use one common SFTP connection for all up and downloads
Now we really wait for all spawned processes to exit
It is only used there
Source maps don't work yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently sourcemaps are not yet working (see #553), but for now I want to let users test the feature and see if additional work is worth it (currently sourcemaps are even not reliable for local execution).
Closes #41