[WIP] Update password creation in vendor scripts based on feedback #3144
+18,688
−18,884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check was reading config and testing if dataDir exists, but then just writing it back without modification. This serves no purpose and has been removed per feedback. Co-authored-by: GermanBluefox <4582016+GermanBluefox@users.noreply.github.com>
Copilot finished work on behalf of
GermanBluefox
December 1, 2025 21:35
GermanBluefox
merged commit eef6c1a
into
javascript-vendor-password
3 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Successfully addressed the feedback from @GermanBluefox regarding the useless dataDir check in
packages/cli/src/lib/setup/setupSetup.ts.Change made: Removed lines 1611-1618 which were reading the config file, checking if dataDir property exists, but then writing it back without any modification.
Validation:
Security Summary
No security concerns. This change removes dead code and does not introduce any new functionality or vulnerabilities.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.