IOMesh monitor review #187
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: nanana-w <78140947+nanana-w@users.noreply.github.com>
Signed-off-by: cospotato <weiqi.lin@smartx.com>
|
|
||
| A user request for a snapshot of a volume, which is similar to a persistent volume request. | ||
|
|
||
| [**Volume Snapshot Class**](https://kubernetes.io/docs/concepts/storage/volume-snapshot-classes/) |
Contributor
There was a problem hiding this comment.
建议和 Volume Snapshot 的位置对调下
Contributor
Author
There was a problem hiding this comment.
volumesnapshotclass 的定义提到了 volumesnapshot, 感觉得先说一下 volumesnapshot？
|
|
||
| Before deploying and using IOMesh, familiarity with the following concepts is suggested. | ||
|
|
||
| [**Kubernetes**](https://kubernetes.io/) |
Contributor
There was a problem hiding this comment.
这一章可不可以采取 有链接的标题带下划虚线，没有链接的不带下划虚线的形式呀；感觉现在这样，页面里有的标题紫有的标题黑，不太和谐
| # Configure ServiceMonitor for Prometheus. | ||
| serviceMonitor: | ||
| create: true # Set it to true to create a serviceMonitor object, which defaults to false. | ||
| namespace: "iomesh-system" # Create a Namespace for serviceMonitor object, which defaults to iomesh-system. |
Contributor
Author
There was a problem hiding this comment.
yixin 说的【是不是这一部分所有的 Namespace 都是应该保持一致的】
| |------|------|--------| | ||
| | Name | The node name. | "node-1" | | ||
| | Namespace | The namespace where the node is located. | "iomesh-system" | | ||
| | Health Status | Shows the node health status, including:<p>Initializing</p><p>Healthy</p><p>Error</p><p>Disconnected</p> | "Healthy"| |
Contributor
There was a problem hiding this comment.
这里的格式不太对，在线文档里没有以 bullet list 形式展现
Co-authored-by: yixin-chen-23 <124547192+yixin-chen-23@users.noreply.github.com>
nanana-w
reviewed
Mar 30, 2023
nanana-w
reviewed
Mar 30, 2023
nanana-w
reviewed
Mar 30, 2023
nanana-w
reviewed
Mar 30, 2023
nanana-w
reviewed
Mar 30, 2023
nanana-w
reviewed
Mar 30, 2023
| | Name | The node name. | "node-1" | | ||
| | Namespace | The namespace where the node is located. | "iomesh-system" | | ||
| | Health Status | Shows the node health status, including:<p>Initializing</p><p>Healthy</p><p>Error</p><p>Disconnected</p> | "Healthy"| | ||
| |Capacity | The total capacity of the node.| "2 TiB" | |
Contributor
There was a problem hiding this comment.
Capacity 和 space usage 和 tower 上的不一致，另外这里表示的是存储容量，用 storage capacity 和 storage capacity usage 是不是更合适？
@yixin-chen-23
nanana-w
reviewed
Mar 30, 2023
nanana-w
reviewed
Mar 30, 2023
nanana-w
reviewed
Mar 30, 2023
nanana-w
reviewed
Mar 30, 2023
nanana-w
reviewed
Mar 30, 2023
cospotato
reviewed
Mar 30, 2023
| # Configure ServiceMonitor for Prometheus. | ||
| serviceMonitor: | ||
| create: true # Set it to true to create a serviceMonitor object, which defaults to false. | ||
| namespace: "iomesh-system" # Create a Namespace for serviceMonitor object, which defaults to iomesh-system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
需要 review 的章节：introduction, basic concepts, monitoring iomesh, iomesh metrics