Clean up public API of FusionException.#427
Merged
toddjonker merged 1 commit intoion-fusion:mainfrom Feb 3, 2026
Merged
Conversation
This prepares for moving it into `runtime.base`. The critical part is the removal of `displayMessage(Evaluator eval)` which coupled this class to implementation details. Due to the preceding changes, all messages are prepared before constructing the exception, so we no longer need that method and can just pull the message from the `Throwable.getMessage()` field.
SharkBaitDLS
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prepares for moving it into
runtime.base. The critical part is the removal ofdisplayMessage(Evaluator eval)which coupled this class to implementation details. Due to the preceding changes, all messages are prepared before constructing the exception, so we no longer need that method and can just pull the message from theThrowable.getMessage()field.Notes
After this change, we can easily move
FusionExceptionintoruntime.base.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.